From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [GIT PULL] Block driver changes for 5.20-rc1
Date: Wed, 3 Aug 2022 19:30:37 +0200 [thread overview]
Message-ID: <20220803173037.GA20921@lst.de> (raw)
In-Reply-To: <CAHk-=wi+HuC_bs7VMTJSjp0vug9DRMY9+jKcsQryU9Eqofdxbg@mail.gmail.com>
On Tue, Aug 02, 2022 at 02:18:57PM -0700, Linus Torvalds wrote:
> This code cannot have gotten much testing at all.
[...]
> And no, I don't want some "fix up broken code after the fact" commit
> on top. I want that code excised, and I don't want to see another pull
> request before it's (a) gone and (b) somebody has looked at where the
> testing of this COMPLETELY failed.
>
Umm. The warning is as you said totally reasonable, and we fixed it as
soon as we got the report. But it turns out my compiler certainly did
not report it (gcc version 10.2.1 20210110 (Debian 10.2.1-6)), Jens's
apparently also did not, and the regular build bot that is running on
tons of architectures did not report it until 9 days after the patch
was commited and pushed out, and until after Jens pulled it.
So while the complaint that we failed to get it into the same pull
request is entirely reasonable, the statement that it cannot have
gotten much testing at all is a bit ridiculous. It's also not that
"I does not compile at all", but rather that -Werror makes a useful
but mostly harmless warning fatal.
next prev parent reply other threads:[~2022-08-03 17:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 15:03 [GIT PULL] Block driver changes for 5.20-rc1 Jens Axboe
2022-08-02 21:18 ` Linus Torvalds
2022-08-02 21:33 ` Keith Busch
2022-08-02 21:35 ` Jens Axboe
2022-08-02 21:50 ` Linus Torvalds
2022-08-02 22:24 ` Jens Axboe
2022-08-02 22:26 ` Jens Axboe
2022-08-02 22:27 ` Linus Torvalds
2022-08-02 22:33 ` Jens Axboe
2022-08-02 22:48 ` Linus Torvalds
2022-08-02 22:59 ` Jens Axboe
2022-08-02 23:03 ` Linus Torvalds
2022-08-02 23:08 ` Jens Axboe
2022-08-03 15:16 ` Jens Axboe
2022-08-03 16:26 ` Linus Torvalds
2022-08-03 16:51 ` Nick Desaulniers
2022-08-03 16:53 ` Jens Axboe
2022-08-03 17:00 ` Linus Torvalds
2022-08-03 17:38 ` Nick Desaulniers
2022-08-03 17:45 ` Jens Axboe
2022-08-03 18:06 ` Nick Desaulniers
2022-08-04 16:17 ` Jens Axboe
2022-08-03 16:56 ` Linus Torvalds
2022-08-03 17:30 ` Christoph Hellwig [this message]
2022-08-03 17:42 ` Linus Torvalds
2022-08-03 17:49 ` Christoph Hellwig
2022-08-03 17:54 ` Linus Torvalds
2022-08-06 7:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803173037.GA20921@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).