linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: bvanassche@acm.org, linux-block@vger.kernel.org,
	dm-devel@redhat.com, snitzer@kernel.org, axboe@kernel.dk,
	hch@lst.de, linux-nvme@lists.infradead.org,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	james.bottomley@hansenpartnership.com
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [PATCH v2 06/20] nvme: Fix reservation status related structs
Date: Mon,  8 Aug 2022 19:04:05 -0500	[thread overview]
Message-ID: <20220809000419.10674-7-michael.christie@oracle.com> (raw)
In-Reply-To: <20220809000419.10674-1-michael.christie@oracle.com>

This fixes the following issues with the reservation status structs:

1. resv10 is bytes 23:10 so it should be 14 bytes.
2. regctl_ds only supports 64 bit host IDs.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 include/linux/nvme.h | 33 +++++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)

diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index ae53d74f3696..ae4a76076420 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -757,20 +757,37 @@ enum {
 	NVME_LBART_ATTRIB_HIDE	= 1 << 1,
 };
 
+struct nvme_registered_ctrl {
+	__le16	cntlid;
+	__u8	rcsts;
+	__u8	rsvd3[5];
+	__le64	hostid;
+	__le64	rkey;
+};
+
+struct nvme_registered_ctrl_ext {
+	__le16	cntlid;
+	__u8	rcsts;
+	__u8	rsvd3[5];
+	__le64	rkey;
+	__u8	hostid[16];
+	__u8	rsvd32[32];
+};
+
 struct nvme_reservation_status {
 	__le32	gen;
 	__u8	rtype;
 	__u8	regctl[2];
 	__u8	resv5[2];
 	__u8	ptpls;
-	__u8	resv10[13];
-	struct {
-		__le16	cntlid;
-		__u8	rcsts;
-		__u8	resv3[5];
-		__le64	hostid;
-		__le64	rkey;
-	} regctl_ds[];
+	__u8	resv10[14];
+	union {
+		struct {
+			__u8	rsvd24[40];
+			struct nvme_registered_ctrl_ext regctl_eds[0];
+		};
+		struct nvme_registered_ctrl regctl_ds[0];
+	};
 };
 
 enum nvme_async_event_type {
-- 
2.18.2


  parent reply	other threads:[~2022-08-09  0:04 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09  0:03 [PATCH 0/20] Use block pr_ops in LIO Mike Christie
2022-08-09  0:04 ` [PATCH v2 01/20] block: Add PR callouts for read keys and reservation Mike Christie
2022-08-09  0:04 ` [PATCH v2 02/20] scsi: Rename sd_pr_command Mike Christie
2022-08-09 19:22   ` Bart Van Assche
2022-08-09  0:04 ` [PATCH v2 03/20] scsi: Move sd_pr_type to header to share Mike Christie
2022-08-09  0:04 ` [PATCH v2 04/20] scsi: Add support for block PR read keys/reservation Mike Christie
2022-08-09 19:26   ` Bart Van Assche
2022-08-10  3:28     ` Mike Christie
2022-08-09  0:04 ` [PATCH v2 05/20] dm: " Mike Christie
2022-08-09  0:04 ` Mike Christie [this message]
2022-08-09  7:19   ` [PATCH v2 06/20] nvme: Fix reservation status related structs Christoph Hellwig
2022-08-09 11:09     ` Chaitanya Kulkarni
2022-08-09  0:04 ` [PATCH v2 07/20] nvme: Don't hardcode the data len for pr commands Mike Christie
2022-08-09  7:19   ` Christoph Hellwig
2022-08-09  0:04 ` [PATCH v2 08/20] nvme: Add helper to convert to a pr_ops PR type Mike Christie
2022-08-09  7:20   ` Christoph Hellwig
2022-08-09 11:12   ` Chaitanya Kulkarni
2022-08-09  0:04 ` [PATCH v2 09/20] nvme: Add helper to execute Reservation Report Mike Christie
2022-08-09 10:55   ` Chaitanya Kulkarni
2022-08-09 16:18     ` Mike Christie
2022-08-09 10:56   ` Chaitanya Kulkarni
2022-08-09 14:51     ` Keith Busch
2022-08-09 16:21       ` Mike Christie
2022-08-10  1:45         ` Chaitanya Kulkarni
2022-08-10  3:17           ` Keith Busch
2022-08-10  4:54             ` Chaitanya Kulkarni
2022-08-09  0:04 ` [PATCH v2 10/20] nvme: Add pr_ops read_keys support Mike Christie
2022-08-09  0:04 ` [PATCH v2 11/20] nvme: Add pr_ops read_reservation support Mike Christie
2022-08-09  0:04 ` [PATCH v2 12/20] block,nvme,scsi,dm: Add blk_status to pr_ops callouts Mike Christie
2022-08-09  7:21   ` Christoph Hellwig
2022-08-09 18:08     ` Mike Christie
2022-08-09 19:33       ` Bart Van Assche
2022-08-10  3:34         ` Mike Christie
2022-08-09  0:04 ` [PATCH v2 13/20] nvme: Have nvme pr_ops return a blk_status_t Mike Christie
2022-08-09 10:58   ` Chaitanya Kulkarni
2022-08-09  0:04 ` [PATCH v2 14/20] scsi: Retry pr_ops commands if a UA is returned Mike Christie
2022-08-09  7:16   ` Christoph Hellwig
2022-08-09 16:24     ` Mike Christie
2022-08-09 19:31       ` Bart Van Assche
2022-08-09  0:04 ` [PATCH v2 15/20] scsi: Export scsi_result_to_blk_status Mike Christie
2022-08-09  0:04 ` [PATCH v2 16/20] scsi: Have sd pr_ops return a blk_status_t Mike Christie
2022-08-09  7:18   ` Christoph Hellwig
2022-08-09 16:22     ` Mike Christie
2022-08-09  0:04 ` [PATCH v2 17/20] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2022-08-09  0:04 ` [PATCH v2 18/20] scsi: target: Allow backends to hook into PR handling Mike Christie
2022-08-09  0:04 ` [PATCH v2 19/20] scsi: target: Don't support SCSI-2 RESERVE/RELEASE Mike Christie
2022-08-09  0:04 ` [PATCH v2 20/20] scsi: target: Add block PR support to iblock Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220809000419.10674-7-michael.christie@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).