From: Christoph Hellwig <hch@lst.de>
To: Mike Christie <michael.christie@oracle.com>
Cc: bvanassche@acm.org, linux-block@vger.kernel.org,
dm-devel@redhat.com, snitzer@kernel.org, axboe@kernel.dk,
hch@lst.de, linux-nvme@lists.infradead.org,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Subject: Re: [PATCH v2 12/20] block,nvme,scsi,dm: Add blk_status to pr_ops callouts.
Date: Tue, 9 Aug 2022 09:21:55 +0200 [thread overview]
Message-ID: <20220809072155.GF11161@lst.de> (raw)
In-Reply-To: <20220809000419.10674-13-michael.christie@oracle.com>
On Mon, Aug 08, 2022 at 07:04:11PM -0500, Mike Christie wrote:
> To handle both cases, this patch adds a blk_status_t arg to the pr_ops
> callouts. The lower levels will convert their device specific error to
> the blk_status_t then the upper levels can easily check that code
> without knowing the device type. It also allows us to keep userspace
> compat where it expects a negative -Exyz error code if the command fails
> before it's sent to the device or a device/tranport specific value if the
> error is > 0.
Why do we need two return values here?
next prev parent reply other threads:[~2022-08-09 7:22 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 0:03 [PATCH 0/20] Use block pr_ops in LIO Mike Christie
2022-08-09 0:04 ` [PATCH v2 01/20] block: Add PR callouts for read keys and reservation Mike Christie
2022-08-09 0:04 ` [PATCH v2 02/20] scsi: Rename sd_pr_command Mike Christie
2022-08-09 19:22 ` Bart Van Assche
2022-08-09 0:04 ` [PATCH v2 03/20] scsi: Move sd_pr_type to header to share Mike Christie
2022-08-09 0:04 ` [PATCH v2 04/20] scsi: Add support for block PR read keys/reservation Mike Christie
2022-08-09 19:26 ` Bart Van Assche
2022-08-10 3:28 ` Mike Christie
2022-08-09 0:04 ` [PATCH v2 05/20] dm: " Mike Christie
2022-08-09 0:04 ` [PATCH v2 06/20] nvme: Fix reservation status related structs Mike Christie
2022-08-09 7:19 ` Christoph Hellwig
2022-08-09 11:09 ` Chaitanya Kulkarni
2022-08-09 0:04 ` [PATCH v2 07/20] nvme: Don't hardcode the data len for pr commands Mike Christie
2022-08-09 7:19 ` Christoph Hellwig
2022-08-09 0:04 ` [PATCH v2 08/20] nvme: Add helper to convert to a pr_ops PR type Mike Christie
2022-08-09 7:20 ` Christoph Hellwig
2022-08-09 11:12 ` Chaitanya Kulkarni
2022-08-09 0:04 ` [PATCH v2 09/20] nvme: Add helper to execute Reservation Report Mike Christie
2022-08-09 10:55 ` Chaitanya Kulkarni
2022-08-09 16:18 ` Mike Christie
2022-08-09 10:56 ` Chaitanya Kulkarni
2022-08-09 14:51 ` Keith Busch
2022-08-09 16:21 ` Mike Christie
2022-08-10 1:45 ` Chaitanya Kulkarni
2022-08-10 3:17 ` Keith Busch
2022-08-10 4:54 ` Chaitanya Kulkarni
2022-08-09 0:04 ` [PATCH v2 10/20] nvme: Add pr_ops read_keys support Mike Christie
2022-08-09 0:04 ` [PATCH v2 11/20] nvme: Add pr_ops read_reservation support Mike Christie
2022-08-09 0:04 ` [PATCH v2 12/20] block,nvme,scsi,dm: Add blk_status to pr_ops callouts Mike Christie
2022-08-09 7:21 ` Christoph Hellwig [this message]
2022-08-09 18:08 ` Mike Christie
2022-08-09 19:33 ` Bart Van Assche
2022-08-10 3:34 ` Mike Christie
2022-08-09 0:04 ` [PATCH v2 13/20] nvme: Have nvme pr_ops return a blk_status_t Mike Christie
2022-08-09 10:58 ` Chaitanya Kulkarni
2022-08-09 0:04 ` [PATCH v2 14/20] scsi: Retry pr_ops commands if a UA is returned Mike Christie
2022-08-09 7:16 ` Christoph Hellwig
2022-08-09 16:24 ` Mike Christie
2022-08-09 19:31 ` Bart Van Assche
2022-08-09 0:04 ` [PATCH v2 15/20] scsi: Export scsi_result_to_blk_status Mike Christie
2022-08-09 0:04 ` [PATCH v2 16/20] scsi: Have sd pr_ops return a blk_status_t Mike Christie
2022-08-09 7:18 ` Christoph Hellwig
2022-08-09 16:22 ` Mike Christie
2022-08-09 0:04 ` [PATCH v2 17/20] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2022-08-09 0:04 ` [PATCH v2 18/20] scsi: target: Allow backends to hook into PR handling Mike Christie
2022-08-09 0:04 ` [PATCH v2 19/20] scsi: target: Don't support SCSI-2 RESERVE/RELEASE Mike Christie
2022-08-09 0:04 ` [PATCH v2 20/20] scsi: target: Add block PR support to iblock Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809072155.GF11161@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).