From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, kbusch@kernel.org, asml.silence@gmail.com,
io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, gost.dev@samsung.com,
Anuj Gupta <anuj20.g@samsung.com>
Subject: Re: [PATCH for-next v4 3/4] block: add helper to map bvec iterator for passthrough
Date: Tue, 6 Sep 2022 08:51:22 +0200 [thread overview]
Message-ID: <20220906065122.GA2190@lst.de> (raw)
In-Reply-To: <20220906063329.GA27127@test-zns>
On Tue, Sep 06, 2022 at 12:03:29PM +0530, Kanchan Joshi wrote:
>> This context looks weird? That bio_alloc_bioset should not be there,
>> as biosets are only used for file system I/O, which this is not.
>
> if you think it's a deal-breaker, maybe I can add a new bioset in nvme and
> pass that as argument to this helper. Would you prefer that over the
> current approach.
The whole point is that biosets exist to allow for forward progress
guarantees required for file system I/O. For passthrough I/O
bio_kmalloc is perfectly fine and much simpler. Adding yet another
bio_set just makes things even worse.
next prev parent reply other threads:[~2022-09-06 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220905135842epcas5p4835d74beb091f5f50490714d93fc58f2@epcas5p4.samsung.com>
2022-09-05 13:48 ` [PATCH for-next v4 0/4] fixed-buffer for uring-cmd/passthru Kanchan Joshi
2022-09-05 13:48 ` [PATCH for-next v4 1/4] io_uring: introduce io_uring_cmd_import_fixed Kanchan Joshi
2022-09-05 17:50 ` Jens Axboe
2022-09-05 17:53 ` Jens Axboe
2022-09-05 13:48 ` [PATCH for-next v4 2/4] io_uring: introduce fixed buffer support for io_uring_cmd Kanchan Joshi
2022-09-05 17:54 ` Jens Axboe
2022-09-05 13:48 ` [PATCH for-next v4 3/4] block: add helper to map bvec iterator for passthrough Kanchan Joshi
2022-09-06 6:25 ` Christoph Hellwig
2022-09-06 6:33 ` Kanchan Joshi
2022-09-06 6:47 ` Kanchan Joshi
2022-09-06 6:51 ` Christoph Hellwig [this message]
2022-09-06 13:06 ` Jens Axboe
2022-09-05 13:48 ` [PATCH for-next v4 4/4] nvme: wire up fixed buffer support for nvme passthrough Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906065122.GA2190@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).