Re: [PATCH for-next v6 1/5] io_uring: add io_uring_cmd_import_fixed

kernel test robot
2022-09-09T02:57:51Z

Hi Kanchan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on linus/master v6.0-rc4 next-20220908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Kanchan-Joshi/io_uring-add-io_uring_cmd_import_fixed/20220909-033508
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220909/202209091034.1uWUabFo-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0b61830b28b6a720a99d34aba08d3d466fe516ec
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Kanchan-Joshi/io_uring-add-io_uring_cmd_import_fixed/20220909-033508
git checkout 0b61830b28b6a720a99d34aba08d3d466fe516ec
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/unix/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from net/unix/scm.c:11:
>> include/linux/io_uring.h:65:5: warning: no previous prototype for function 'io_uring_cmd_import_fixed' [-Wmissing-prototypes]
int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
^
include/linux/io_uring.h:65:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
^
static
1 warning generated.

vim +/io_uring_cmd_import_fixed +65 include/linux/io_uring.h

46
47 static inline void io_uring_files_cancel(void)
48 {
49 if (current->io_uring) {
50 io_uring_unreg_ringfd();
51 __io_uring_cancel(false);
52 }
53 }
54 static inline void io_uring_task_cancel(void)
55 {
56 if (current->io_uring)
57 __io_uring_cancel(true);
58 }
59 static inline void io_uring_free(struct task_struct *tsk)
60 {
61 if (tsk->io_uring)
62 __io_uring_free(tsk);
63 }
64 #else
> 65 int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
66 struct iov_iter *iter, void *ioucmd)
67 {
68 return -EOPNOTSUPP;
69 }
70 static inline void io_uring_cmd_done(struct io_uring_cmd *cmd, ssize_t ret,
71 ssize_t ret2)
72 {
73 }
74 static inline void io_uring_cmd_complete_in_task(struct io_uring_cmd *ioucmd,
75 void (*task_work_cb)(struct io_uring_cmd *))
76 {
77 }
78 static inline struct sock *io_uring_get_socket(struct file *file)
79 {
80 return NULL;
81 }
82 static inline void io_uring_task_cancel(void)
83 {
84 }
85 static inline void io_uring_files_cancel(void)
86 {
87 }
88 static inline void io_uring_free(struct task_struct *tsk)
89 {
90 }
91 static inline const char *io_uring_get_opcode(u8 opcode)
92 {
93 return "";
94 }
95 #endif
96

--
0-DAY CI Kernel Test Service