From: Pankaj Raghav <p.raghav@samsung.com>
To: hch@lst.de, agk@redhat.com, damien.lemoal@opensource.wdc.com,
axboe@kernel.dk, snitzer@kernel.org
Cc: linux-kernel@vger.kernel.org, Johannes.Thumshirn@wdc.com,
linux-nvme@lists.infradead.org, pankydev8@gmail.com,
matias.bjorling@wdc.com, linux-block@vger.kernel.org,
bvanassche@acm.org, gost.dev@samsung.com, dm-devel@redhat.com,
hare@suse.de, jaegeuk@kernel.org,
Pankaj Raghav <p.raghav@samsung.com>
Subject: [PATCH v13 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices
Date: Mon, 12 Sep 2022 10:22:02 +0200 [thread overview]
Message-ID: <20220912082204.51189-12-p.raghav@samsung.com> (raw)
In-Reply-To: <20220912082204.51189-1-p.raghav@samsung.com>
dm_zone_endio() updates the bi_sector of orig bio for zoned devices that
uses either native append or append emulation, and it is called before the
endio of the target. But target endio can still update the clone bio
after dm_zone_endio is called, thereby, the orig bio does not contain
the updated information anymore.
Currently, this is not a problem as the targets that support zoned devices
such as dm-zoned, dm-linear, and dm-crypt do not have an endio function,
and even if they do (such as dm-flakey), they don't modify the
bio->bi_iter.bi_sector of the cloned bio that is used to update the
orig_bio's bi_sector in dm_zone_endio function.
This is a prep patch for the new dm-po2zoned target as it modifies
bi_sector in the endio callback.
Call dm_zone_endio for zoned devices after calling the target's endio
function.
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
drivers/md/dm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 7c35dea88ed1..874e1dc9fc26 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -1122,10 +1122,6 @@ static void clone_endio(struct bio *bio)
disable_write_zeroes(md);
}
- if (static_branch_unlikely(&zoned_enabled) &&
- unlikely(bdev_is_zoned(bio->bi_bdev)))
- dm_zone_endio(io, bio);
-
if (endio) {
int r = endio(ti, bio, &error);
switch (r) {
@@ -1154,6 +1150,10 @@ static void clone_endio(struct bio *bio)
}
}
+ if (static_branch_unlikely(&zoned_enabled) &&
+ unlikely(bdev_is_zoned(bio->bi_bdev)))
+ dm_zone_endio(io, bio);
+
if (static_branch_unlikely(&swap_bios_enabled) &&
unlikely(swap_bios_limit(ti, bio)))
up(&md->swap_bios_semaphore);
--
2.25.1
next prev parent reply other threads:[~2022-09-12 8:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220912082205eucas1p1e5fb1acfb0b2a2fe6261520ace90c883@eucas1p1.samsung.com>
2022-09-12 8:21 ` [PATCH v13 00/13] support zoned block devices with non-power-of-2 zone sizes Pankaj Raghav
2022-09-12 8:21 ` [PATCH v13 01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size Pankaj Raghav
2022-09-12 10:03 ` Johannes Thumshirn
2022-09-14 17:19 ` Chaitanya Kulkarni
2022-09-12 8:21 ` [PATCH v13 02/13] block: rearrange bdev_{is_zoned,zone_sectors,get_queue} helper in blkdev.h Pankaj Raghav
2022-09-12 10:03 ` Johannes Thumshirn
2022-09-14 17:19 ` Chaitanya Kulkarni
2022-09-12 8:21 ` [PATCH v13 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-09-12 10:04 ` Johannes Thumshirn
2022-09-12 8:21 ` [PATCH v13 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Pankaj Raghav
2022-09-14 17:16 ` Chaitanya Kulkarni
2022-09-12 8:21 ` [PATCH v13 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size Pankaj Raghav
2022-09-14 17:16 ` Chaitanya Kulkarni
2022-09-12 8:21 ` [PATCH v13 06/13] null_blk: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-12 10:06 ` Johannes Thumshirn
2022-09-14 17:17 ` Chaitanya Kulkarni
2022-09-12 8:21 ` [PATCH v13 07/13] zonefs: allow non power of 2 zoned devices Pankaj Raghav
2022-09-12 10:07 ` Johannes Thumshirn
2022-09-14 17:17 ` Chaitanya Kulkarni
2022-09-12 8:21 ` [PATCH v13 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-09-12 10:07 ` Johannes Thumshirn
2022-09-12 8:22 ` [PATCH v13 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
2022-09-12 10:08 ` Johannes Thumshirn
2022-09-12 8:22 ` [PATCH v13 10/13] dm-table: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-12 10:08 ` Johannes Thumshirn
2022-09-12 8:22 ` Pankaj Raghav [this message]
2022-09-12 8:22 ` [PATCH v13 12/13] dm: introduce DM_EMULATED_ZONES target feature flag Pankaj Raghav
2022-09-12 8:22 ` [PATCH v13 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-14 16:52 ` Mike Snitzer
2022-09-14 19:16 ` Pankaj Raghav
2022-09-16 17:57 ` Pankaj Raghav
2022-09-16 18:04 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912082204.51189-12-p.raghav@samsung.com \
--to=p.raghav@samsung.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=matias.bjorling@wdc.com \
--cc=pankydev8@gmail.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox