public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Raghav <p.raghav@samsung.com>
To: hch@lst.de, agk@redhat.com, damien.lemoal@opensource.wdc.com,
	axboe@kernel.dk, snitzer@kernel.org
Cc: linux-kernel@vger.kernel.org, Johannes.Thumshirn@wdc.com,
	linux-nvme@lists.infradead.org, pankydev8@gmail.com,
	matias.bjorling@wdc.com, linux-block@vger.kernel.org,
	bvanassche@acm.org, gost.dev@samsung.com, dm-devel@redhat.com,
	hare@suse.de, jaegeuk@kernel.org,
	Pankaj Raghav <p.raghav@samsung.com>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH v13 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes
Date: Mon, 12 Sep 2022 10:21:55 +0200	[thread overview]
Message-ID: <20220912082204.51189-5-p.raghav@samsung.com> (raw)
In-Reply-To: <20220912082204.51189-1-p.raghav@samsung.com>

A generic bdev_zone_no() helper is added to calculate zone number for a
given sector in a block device. This helper internally uses disk_zone_no()
to find the zone number.

Use the helper bdev_zone_no() to calculate nr of zones. This let's us
make modifications to the math if needed in one place and adds now
support for zoned devices with non po2 zone size.

Reviewed by: Adam Manzanares <a.manzanares@samsung.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
 drivers/nvme/target/zns.c | 3 +--
 include/linux/blkdev.h    | 5 +++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c
index c7ef69f29fe4..662f1a92f39b 100644
--- a/drivers/nvme/target/zns.c
+++ b/drivers/nvme/target/zns.c
@@ -241,8 +241,7 @@ static unsigned long nvmet_req_nr_zones_from_slba(struct nvmet_req *req)
 {
 	unsigned int sect = nvmet_lba_to_sect(req->ns, req->cmd->zmr.slba);
 
-	return bdev_nr_zones(req->ns->bdev) -
-		(sect >> ilog2(bdev_zone_sectors(req->ns->bdev)));
+	return bdev_nr_zones(req->ns->bdev) - bdev_zone_no(req->ns->bdev, sect);
 }
 
 static unsigned long get_nr_zones_from_buf(struct nvmet_req *req, u32 bufsize)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index d0d66a0db224..b2636dcca105 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1340,6 +1340,11 @@ static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 	return BLK_ZONED_NONE;
 }
 
+static inline unsigned int bdev_zone_no(struct block_device *bdev, sector_t sec)
+{
+	return disk_zone_no(bdev->bd_disk, sec);
+}
+
 static inline int queue_dma_alignment(const struct request_queue *q)
 {
 	return q ? q->dma_alignment : 511;
-- 
2.25.1


  parent reply	other threads:[~2022-09-12  8:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220912082205eucas1p1e5fb1acfb0b2a2fe6261520ace90c883@eucas1p1.samsung.com>
2022-09-12  8:21 ` [PATCH v13 00/13] support zoned block devices with non-power-of-2 zone sizes Pankaj Raghav
2022-09-12  8:21   ` [PATCH v13 01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size Pankaj Raghav
2022-09-12 10:03     ` Johannes Thumshirn
2022-09-14 17:19     ` Chaitanya Kulkarni
2022-09-12  8:21   ` [PATCH v13 02/13] block: rearrange bdev_{is_zoned,zone_sectors,get_queue} helper in blkdev.h Pankaj Raghav
2022-09-12 10:03     ` Johannes Thumshirn
2022-09-14 17:19     ` Chaitanya Kulkarni
2022-09-12  8:21   ` [PATCH v13 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-09-12 10:04     ` Johannes Thumshirn
2022-09-12  8:21   ` Pankaj Raghav [this message]
2022-09-14 17:16     ` [PATCH v13 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Chaitanya Kulkarni
2022-09-12  8:21   ` [PATCH v13 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size Pankaj Raghav
2022-09-14 17:16     ` Chaitanya Kulkarni
2022-09-12  8:21   ` [PATCH v13 06/13] null_blk: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-12 10:06     ` Johannes Thumshirn
2022-09-14 17:17     ` Chaitanya Kulkarni
2022-09-12  8:21   ` [PATCH v13 07/13] zonefs: allow non power of 2 zoned devices Pankaj Raghav
2022-09-12 10:07     ` Johannes Thumshirn
2022-09-14 17:17     ` Chaitanya Kulkarni
2022-09-12  8:21   ` [PATCH v13 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-09-12 10:07     ` Johannes Thumshirn
2022-09-12  8:22   ` [PATCH v13 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
2022-09-12 10:08     ` Johannes Thumshirn
2022-09-12  8:22   ` [PATCH v13 10/13] dm-table: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-12 10:08     ` Johannes Thumshirn
2022-09-12  8:22   ` [PATCH v13 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices Pankaj Raghav
2022-09-12  8:22   ` [PATCH v13 12/13] dm: introduce DM_EMULATED_ZONES target feature flag Pankaj Raghav
2022-09-12  8:22   ` [PATCH v13 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-14 16:52     ` Mike Snitzer
2022-09-14 19:16       ` Pankaj Raghav
2022-09-16 17:57         ` Pankaj Raghav
2022-09-16 18:04           ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220912082204.51189-5-p.raghav@samsung.com \
    --to=p.raghav@samsung.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=gost.dev@samsung.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=matias.bjorling@wdc.com \
    --cc=mcgrof@kernel.org \
    --cc=pankydev8@gmail.com \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox