From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, "Ming Lei" <ming.lei@redhat.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Huang Ying" <ying.huang@intel.com>,
"Michal Koutný" <mkoutny@suse.com>,
"Waiman Long" <longman@redhat.com>
Subject: [PATCH v7 0/3] blk-cgroup: Optimize blkcg_rstat_flush()
Date: Mon, 3 Oct 2022 11:44:56 -0400 [thread overview]
Message-ID: <20221003154459.207538-1-longman@redhat.com> (raw)
v7:
- Drop patch 1 ("blk-cgroup: Correctly free percpu iostat_cpu in blkg
on error exit") as it is found to be unnecessary.
- Add a new llist patch to provide a lockless list variant terminated
by a sentinel node.
- Modified patch 3 to use the new sllist API and move percpu_ref_put()
later in the blkcg_rstat_flush() loop to prevent potential
use-after-free problem.
v6:
- Add a missing free_percpu() into blkcg_css_free() in patch 3.
- Integrating the documentation patch 4 back into patch 3.
v5:
- Add a new patch 2 to eliminate the use of intermediate "ret"
variable in blkcg_css_alloc() to fix compilation warning reported
by kernel test robot.
This patch series improves blkcg_rstat_flush() performance by eliminating
unnecessary blkg enumeration and flush operations for those blkg's and
blkg_iostat_set's that haven't been updated since the last flush.
Waiman Long (3):
llist: Add a lock-less list variant terminated by a sentinel node
blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path
blk-cgroup: Optimize blkcg_rstat_flush()
block/blk-cgroup.c | 85 ++++++++++++++++++++++-----
block/blk-cgroup.h | 9 +++
include/linux/llist.h | 132 +++++++++++++++++++++++++++++++++++++++++-
lib/llist.c | 79 ++++++++++++++++++++++++-
4 files changed, 289 insertions(+), 16 deletions(-)
--
2.31.1
next reply other threads:[~2022-10-03 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 15:44 Waiman Long [this message]
2022-10-03 15:44 ` [PATCH v7 1/3] llist: Add a lock-less list variant terminated by a sentinel node Waiman Long
2022-10-03 16:40 ` Tejun Heo
2022-10-03 16:55 ` Waiman Long
2022-10-03 16:57 ` Tejun Heo
2022-10-03 17:32 ` Waiman Long
2022-10-03 17:36 ` Tejun Heo
2022-10-03 17:40 ` Waiman Long
2022-10-03 19:39 ` Waiman Long
2022-10-03 20:15 ` Tejun Heo
2022-10-08 2:15 ` Huang, Ying
2022-10-03 15:44 ` [PATCH v7 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path Waiman Long
2022-10-03 16:40 ` Tejun Heo
2022-10-03 15:44 ` [PATCH v7 3/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221003154459.207538-1-longman@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox