linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Roesch <shr@devkernel.io>
To: kernel-team@fb.com, linux-block@vger.kernel.org, linux-mm@kvack.org
Cc: shr@devkernel.io, axboe@kernel.dk, clm@meta.com
Subject: [RFC PATCH v1 00/14] mm/block: add bdi sysfs knobs
Date: Mon, 10 Oct 2022 18:00:30 -0700	[thread overview]
Message-ID: <20221011010044.851537-1-shr@devkernel.io> (raw)

At meta network block devices (nbd) are used to implement remote block storage. In testing
and during production it has been observed that these network block devices can consume
a huge portion of the dirty writeback and writeback can take a considerable time.

To give stricter limits, I'm proposing the following changes and new sysfs knobs:

1) strictlimit knob
  Currently the max_ratio knob exists to limit the dirty_memory. However this knob
  only applies once (dirty_ratio + dirty_background_ratio) / 2 has been reached.
  With the BDI_CAP_STRICTLIMIT flag, the max_ratio can be applied without reaching
  that limit. This change exposes that knob.

  This knob can also be useful for NFS, fuse filesystems and USB devices.

2) Part of 10000 internal calculation
  The max_ratio is based on percentage. With the current machine sizes percentage
  values can be very high (1% of a 256GB main memory is already 2.5GB). This change
  uses part of 10000 instead of percentages for the internal calculations.

3) Introduce two new knobs: min_bytes and max_bytes.
  Currently all calculations are based on ratio, but for a user it often more
  convenient to specify a limit in bytes. The new knobs will not store bytes values,
  instead they will translate the byte value to a corresponding ratio. As the internal
  values are now part of 10000, the ratio is closer to the specified value. However
  the value should be more seen as an approximation as it can fluctuate over time.


Stefan Roesch (14):
  mm: add bdi_set_strict_limit() function
  mm: Add new knob /sys/class/bdi/<bdi>/strict_limit
  mm: document new /sys/class/bdi/<bdi>/strict_limit knob
  mm: Use part per 10000 for bdi ratios.
  mm: add bdi_get_max_bytes() function
  mm: split off __bdi_set_max_ratio() function
  mm: add bdi_set_max_bytes() function.
  mm: Add new knob /sys/class/bdi/<bdi>/max_bytes
  mm: document new /sys/class/bdi/<bdi>/max_bytes knob
  mm: add bdi_get_min_bytes() function.
  mm: split off __bdi_set_min_ratio() function
  mm: add bdi_set_min_bytes() function
  mm: add new /sys/class/bdi/<bdi>/min_bytes knob
  mm: document new /sys/class/bdi/<bdi>/min_bytes knob

 Documentation/ABI/testing/sysfs-class-bdi |  40 +++++++
 include/linux/backing-dev.h               |   8 ++
 mm/backing-dev.c                          |  93 +++++++++++++++-
 mm/page-writeback.c                       | 126 ++++++++++++++++++++--
 4 files changed, 253 insertions(+), 14 deletions(-)


base-commit: e2302539dd4f1c62d96651c07ddb05aa2461d29c
-- 
2.30.2


             reply	other threads:[~2022-10-11  1:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  1:00 Stefan Roesch [this message]
2022-10-11  1:00 ` [RFC PATCH v1 01/14] mm: add bdi_set_strict_limit() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 02/14] mm: Add new knob /sys/class/bdi/<bdi>/strict_limit Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 03/14] mm: document new /sys/class/bdi/<bdi>/strict_limit knob Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 04/14] mm: Use part per 10000 for bdi ratios Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 05/14] mm: add bdi_get_max_bytes() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 06/14] mm: split off __bdi_set_max_ratio() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 07/14] mm: add bdi_set_max_bytes() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 08/14] mm: Add new knob /sys/class/bdi/<bdi>/max_bytes Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 09/14] mm: document new /sys/class/bdi/<bdi>/max_bytes knob Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 10/14] mm: add bdi_get_min_bytes() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 11/14] mm: split off __bdi_set_min_ratio() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 12/14] mm: add bdi_set_min_bytes() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 13/14] mm: add new /sys/class/bdi/<bdi>/min_bytes knob Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 14/14] mm: document " Stefan Roesch
2022-10-11 18:20 ` [RFC PATCH v1 00/14] mm/block: add bdi sysfs knobs Matthew Wilcox
2022-10-13 20:11   ` Stefan Roesch
2022-10-17  7:45 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011010044.851537-1-shr@devkernel.io \
    --to=shr@devkernel.io \
    --cc=axboe@kernel.dk \
    --cc=clm@meta.com \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).