From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org
Subject: don't drop the queue reference in blk_mq_destroy_queue
Date: Tue, 18 Oct 2022 15:57:16 +0200 [thread overview]
Message-ID: <20221018135720.670094-1-hch@lst.de> (raw)
Hi all,
currently blk_mq_destroy_queue not only shuts down the queue, but also
drops a queue references, which leads to the NVMe PCIe/Apple drivers and
scsi grabbing an extra references. Fix this to help with unifying more
code between the various NVMe drivers (and to make the code a little saner
even on it's own).
Diffstat:
block/blk-mq.c | 4 +---
block/bsg-lib.c | 2 ++
drivers/nvme/host/apple.c | 8 --------
drivers/nvme/host/core.c | 10 ++++++++--
drivers/nvme/host/pci.c | 5 -----
drivers/scsi/scsi_scan.c | 1 -
drivers/ufs/core/ufshcd.c | 2 ++
7 files changed, 13 insertions(+), 19 deletions(-)
next reply other threads:[~2022-10-18 13:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 13:57 Christoph Hellwig [this message]
2022-10-18 13:57 ` [PATCH 1/4] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue Christoph Hellwig
2022-10-18 20:44 ` Chaitanya Kulkarni
2022-10-19 8:19 ` Sagi Grimberg
2022-10-25 14:23 ` Jens Axboe
2022-10-25 14:25 ` Jens Axboe
2022-10-18 13:57 ` [PATCH 2/4] scsi: remove an extra queue reference Christoph Hellwig
2022-10-18 20:44 ` Chaitanya Kulkarni
2022-10-19 1:16 ` Ming Lei
2022-10-19 1:23 ` Ming Lei
2022-10-19 8:19 ` Sagi Grimberg
2022-10-18 13:57 ` [PATCH 3/4] nvme-pci: " Christoph Hellwig
2022-10-18 20:44 ` Chaitanya Kulkarni
2022-10-19 8:19 ` Sagi Grimberg
2022-10-18 13:57 ` [PATCH 4/4] nvme-apple: " Christoph Hellwig
2022-10-18 17:51 ` Sven Peter
2022-10-18 20:45 ` Chaitanya Kulkarni
2022-10-19 8:19 ` Sagi Grimberg
2022-10-18 15:16 ` don't drop the queue reference in blk_mq_destroy_queue Keith Busch
2022-10-25 14:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018135720.670094-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox