From: Ye Bin <yebin@huaweicloud.com>
To: axboe@kernel.dk, rostedt@goodmis.org, mhiramat@kernel.org,
linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, yebin@huaweicloud.com,
Ye Bin <yebin10@huawei.com>
Subject: [PATCH v3 3/3] blktrace: remove unnessary stop block trace in 'blk_trace_shutdown'
Date: Wed, 19 Oct 2022 11:36:02 +0800 [thread overview]
Message-ID: <20221019033602.752383-4-yebin@huaweicloud.com> (raw)
In-Reply-To: <20221019033602.752383-1-yebin@huaweicloud.com>
From: Ye Bin <yebin10@huawei.com>
As previous commit, 'blk_trace_cleanup' will stop block trace if
block trace's state is 'Blktrace_running'.
So remove unnessary stop block trace in 'blk_trace_shutdown'.
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
kernel/trace/blktrace.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index e17bba027a2c..a995ea1ef849 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -776,10 +776,8 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg)
void blk_trace_shutdown(struct request_queue *q)
{
if (rcu_dereference_protected(q->blk_trace,
- lockdep_is_held(&q->debugfs_mutex))) {
- __blk_trace_startstop(q, 0);
+ lockdep_is_held(&q->debugfs_mutex)))
__blk_trace_remove(q);
- }
}
#ifdef CONFIG_BLK_CGROUP
--
2.31.1
next prev parent reply other threads:[~2022-10-19 3:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 3:35 [PATCH v3 0/3] fix possible memleak in '__blk_trace_remove' Ye Bin
2022-10-19 3:36 ` [PATCH v3 1/3] blktrace: introduce 'blk_trace_{start,stop}' helper Ye Bin
2022-10-20 8:04 ` Christoph Hellwig
2022-10-19 3:36 ` [PATCH v3 2/3] blktrace: fix possible memleak in '__blk_trace_remove' Ye Bin
2022-10-20 8:04 ` Christoph Hellwig
2022-10-19 3:36 ` Ye Bin [this message]
2022-10-20 8:04 ` [PATCH v3 3/3] blktrace: remove unnessary stop block trace in 'blk_trace_shutdown' Christoph Hellwig
2022-10-20 13:03 ` [PATCH v3 0/3] fix possible memleak in '__blk_trace_remove' Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019033602.752383-4-yebin@huaweicloud.com \
--to=yebin@huaweicloud.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).