public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Yi Zhang <yi.zhang@redhat.com>
To: logang@deltatee.com, shinichiro.kawasaki@wdc.com
Cc: linux-block@vger.kernel.org, sandeen@sandeen.net
Subject: [PATCH blktests] common/xfs: ignore the 32M log size during mkfs.xfs
Date: Wed, 19 Oct 2022 13:12:44 +0800	[thread overview]
Message-ID: <20221019051244.810755-1-yi.zhang@redhat.com> (raw)

The new minimum size for the xfs log is 64MB which introudced from
xfsprogs v5.19.0, let's ignore it, or nvme/013 will be failed at:

$ mkfs.xfs -l size=32m -f /dev/nvme0n1
Log size must be at least 64MB.
Usage: mkfs.xfs
/* blocksize */		[-b size=num]
/* config file */	[-c options=xxx]
/* metadata */		[-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1,
			    inobtcount=0|1,bigtime=0|1]
/* data subvol */	[-d agcount=n,agsize=n,file,name=xxx,size=num,
			    (sunit=value,swidth=value|su=num,sw=num|noalign),
			    sectsize=num
/* force overwrite */	[-f]
/* inode size */	[-i perblock=n|size=num,maxpct=n,attr=0|1|2,
			    projid32bit=0|1,sparse=0|1,nrext64=0|1]
/* no discard */	[-K]
/* log subvol */	[-l agnum=n,internal,size=num,logdev=xxx,version=n
			    sunit=value|su=num,sectsize=num,lazy-count=0|1]
/* label */		[-L label (maximum 12 characters)]
/* naming */		[-n size=num,version=2|ci,ftype=0|1]
/* no-op info only */	[-N]
/* prototype file */	[-p fname]
/* quiet */		[-q]
/* realtime subvol */	[-r extsize=num,size=num,rtdev=xxx]
/* sectorsize */	[-s size=num]
/* version */		[-V]
			devicename
<devicename> is required unless -d name=xxx is given.
<num> is xxx (bytes), xxxs (sectors), xxxb (fs blocks), xxxk (xxx KiB),
      xxxm (xxx MiB), xxxg (xxx GiB), xxxt (xxx TiB) or xxxp (xxx PiB).
<value> is xxx (512 byte blocks).

Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
 common/xfs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/xfs b/common/xfs
index 210c924..f0c9b7f 100644
--- a/common/xfs
+++ b/common/xfs
@@ -16,7 +16,7 @@ _xfs_mkfs_and_mount() {
 
 	mkdir -p "${mount_dir}"
 	umount "${mount_dir}"
-	mkfs.xfs -l size=32m -f "${bdev}"
+	mkfs.xfs -f "${bdev}"
 	mount "${bdev}" "${mount_dir}"
 }
 
-- 
2.34.1


             reply	other threads:[~2022-10-19  5:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19  5:12 Yi Zhang [this message]
2022-10-19  6:06 ` [PATCH blktests] common/xfs: ignore the 32M log size during mkfs.xfs Chaitanya Kulkarni
2022-10-19  6:16 ` Chaitanya Kulkarni
2022-10-19 14:19   ` Eric Sandeen
2022-10-19 19:18     ` Chaitanya Kulkarni
2022-10-21  8:58       ` Shinichiro Kawasaki
2022-10-21 21:42         ` Chaitanya Kulkarni
2022-10-21 23:56           ` Shinichiro Kawasaki
2022-10-23 15:27             ` Yi Zhang
2022-10-24  0:50               ` Shinichiro Kawasaki
2022-10-24  6:32                 ` Yi Zhang
2022-10-24 10:31                   ` Shinichiro Kawasaki
2022-10-25  0:42                 ` Chaitanya Kulkarni
2022-10-25  1:53                   ` Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221019051244.810755-1-yi.zhang@redhat.com \
    --to=yi.zhang@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=sandeen@sandeen.net \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox