Re: [PATCH blktests] common/xfs: ignore the 32M log size during mkfs.xfs

Yi Zhang
2022-10-23T15:28:04Z

On Sat, Oct 22, 2022 at 7:57 AM Shinichiro Kawasaki
<shinichiro.kawasaki@wdc.com> wrote:
>
> On Oct 21, 2022 / 21:42, Chaitanya Kulkarni wrote:
>
> ...
>
> > I think creating a minimal setup is a part of the testcase and we should
> > not change it, unless there is a explicit reason for doing so.
>
> I see, I find no reason to change the "minimal log size policy". Let's go with
> 64MB log size to keep it.
>
> Yi, would you mind reposting v2 with size=64m?
Sure, and before I post it, I want to ask for suggestions about some
other code changes:

After set log size with 64M, I found nvme/012 nvme/013 will be
failed[1], and there was not enough space for fio with size=950m
testing.
Either [2] or [3] works, which one do you prefer, or do you have some
other suggestion for it? Thanks.

[1]
nvme/012 (run mkfs and data verification fio job on NVMeOF block
device-backed ns) [failed]
runtime 54.400s ... 53.514s
--- tests/nvme/012.out 2022-10-21 10:21:12.461157830 -0400
+++ /root/blktests/results/nodev/nvme/012.out.bad 2022-10-23
09:10:01.125990759 -0400
@@ -1,5 +1,22 @@
Running nvme/012
91fdba0d-f87b-4c25-b80f-db7be1418b9e
uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
+fio: io_u error on file /mnt/blktests//verify.0.0: No space left
on device: write offset=292646912, buflen=4096
+fio: io_u error on file /mnt/blktests//verify.0.0: No space left
on device: write offset=336576512, buflen=4096
+fio: io_u error on file /mnt/blktests//verify.0.0: No space left
on device: write offset=144633856, buflen=4096
+fio: io_u error on file /mnt/blktests//verify.0.0: No space left
on device: write offset=149147648, buflen=4096
...
(Run 'diff -u tests/nvme/012.out
/root/blktests/results/nodev/nvme/012.out.bad' to see the entire diff)
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed
ns) [failed]
runtime 172.121s ... 292.743s
--- tests/nvme/013.out 2022-10-21 10:21:12.461157830 -0400
+++ /root/blktests/results/nodev/nvme/013.out.bad 2022-10-23
09:14:43.493752127 -0400
@@ -1,5 +1,17 @@
Running nvme/013
91fdba0d-f87b-4c25-b80f-db7be1418b9e
uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
+fio: io_u error on file /mnt/blktests//verify.0.0: No space left
on device: write offset=665759744, buflen=4096
+fio: io_u error on file /mnt/blktests//verify.0.0: No space left
on device: write offset=198172672, buflen=4096
+fio: io_u error on file /mnt/blktests//verify.0.0: No space left
on device: write offset=369643520, buflen=4096
+fio: io_u error on file /mnt/blktests//verify.0.0: No space left
on device: write offset=195624960, buflen=4096
...
(Run 'diff -u tests/nvme/013.out
/root/blktests/results/nodev/nvme/013.out.bad' to see the entire diff)

[2]
diff --git a/tests/nvme/012 b/tests/nvme/012
index c9d2438..25bde25 100755
--- a/tests/nvme/012
+++ b/tests/nvme/012
@@ -29,7 +29,7 @@ test() {
local file_path="${TMPDIR}/img"
local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s 2G "${file_path}"

loop_dev="$(losetup -f --show "${file_path}")"

diff --git a/tests/nvme/013 b/tests/nvme/013
index 265b696..602c86f 100755
--- a/tests/nvme/013
+++ b/tests/nvme/013
@@ -28,7 +28,7 @@ test() {

local subsys_name="blktests-subsystem-1"

- truncate -s 1G "${file_path}"
+ truncate -s 2G "${file_path}"

_create_nvmet_subsystem "${subsys_name}" "${file_path}" \
"91fdba0d-f87b-4c25-b80f-db7be1418b9e"
[3]
diff --git a/common/xfs b/common/xfs
index 210c924..0018212 100644
--- a/common/xfs
+++ b/common/xfs
@@ -26,7 +26,7 @@ _xfs_run_fio_verify_io() {

_xfs_mkfs_and_mount "${bdev}" "${mount_dir}" >> "${FULL}" 2>&1

- _run_fio_verify_io --size=950m --directory="${mount_dir}/"
+ _run_fio_verify_io --size=900m --directory="${mount_dir}/"

umount "${mount_dir}" >> "${FULL}" 2>&1
rm -fr "${mount_dir}"
>
> --
> Shin'ichiro Kawasaki
>

--
Best Regards,
Yi Zhang