From: Yi Zhang <yi.zhang@redhat.com>
To: shinichiro.kawasaki@wdc.com
Cc: chaitanyak@nvidia.com, linux-block@vger.kernel.org
Subject: [PATCH V2 blktests 3/3] nvme/012,013,035: change fio I/O size and move size definition place
Date: Wed, 2 Nov 2022 10:57:02 +0800 [thread overview]
Message-ID: <20221102025702.1664101-4-yi.zhang@redhat.com> (raw)
In-Reply-To: <20221102025702.1664101-1-yi.zhang@redhat.com>
Change fio I/O size of nvme/012,013,035 from 950m to 900m, since recent change
increased the xfs log size and it caused fio failure with I/O size 950m.
Also add size parameter to _run_fio_verify_io. This allows to move the fio I/O
size definition from common/xfs to the test case, so that device size and fio
I/O size are both defined at single place.
Link: https://lore.kernel.org/linux-block/20221019051244.810755-1-yi.zhang@redhat.com/
Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
common/xfs | 3 ++-
tests/nvme/012 | 2 +-
tests/nvme/013 | 2 +-
tests/nvme/035 | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/common/xfs b/common/xfs
index 846a5ef..2c5d961 100644
--- a/common/xfs
+++ b/common/xfs
@@ -23,10 +23,11 @@ _xfs_mkfs_and_mount() {
_xfs_run_fio_verify_io() {
local mount_dir="/mnt/blktests"
local bdev=$1
+ local sz=$2
_xfs_mkfs_and_mount "${bdev}" "${mount_dir}" >> "${FULL}" 2>&1
- _run_fio_verify_io --size=950m --directory="${mount_dir}/"
+ _run_fio_verify_io --size="$sz" --directory="${mount_dir}/"
umount "${mount_dir}" >> "${FULL}" 2>&1
rm -fr "${mount_dir}"
diff --git a/tests/nvme/012 b/tests/nvme/012
index c9d2438..e60082c 100755
--- a/tests/nvme/012
+++ b/tests/nvme/012
@@ -44,7 +44,7 @@ test() {
cat "/sys/block/${nvmedev}n1/uuid"
cat "/sys/block/${nvmedev}n1/wwid"
- _xfs_run_fio_verify_io "/dev/${nvmedev}n1"
+ _xfs_run_fio_verify_io "/dev/${nvmedev}n1" "900m"
_nvme_disconnect_subsys "${subsys_name}"
diff --git a/tests/nvme/013 b/tests/nvme/013
index 265b696..9d60a7d 100755
--- a/tests/nvme/013
+++ b/tests/nvme/013
@@ -41,7 +41,7 @@ test() {
cat "/sys/block/${nvmedev}n1/uuid"
cat "/sys/block/${nvmedev}n1/wwid"
- _xfs_run_fio_verify_io "/dev/${nvmedev}n1"
+ _xfs_run_fio_verify_io "/dev/${nvmedev}n1" "900m"
_nvme_disconnect_subsys "${subsys_name}"
diff --git a/tests/nvme/035 b/tests/nvme/035
index e8581ef..d169e35 100755
--- a/tests/nvme/035
+++ b/tests/nvme/035
@@ -32,7 +32,7 @@ test_device() {
port=$(_nvmet_passthru_target_setup "${subsys}")
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${subsys}")
- _xfs_run_fio_verify_io "${nsdev}"
+ _xfs_run_fio_verify_io "${nsdev}" "900m"
_nvme_disconnect_subsys "${subsys}"
_nvmet_passthru_target_cleanup "${port}" "${subsys}"
--
2.34.1
next prev parent reply other threads:[~2022-11-02 2:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 2:56 [PATCH V2 blktests 0/3] fix and improvement for xfs log size change from new xfsprogs version Yi Zhang
2022-11-02 2:57 ` [PATCH V2 blktests 1/3] common/xfs: set the minimal log size 64m during mkfs.xfs Yi Zhang
2022-11-02 2:57 ` [PATCH V2 blktests 2/3] common/rc: add one function to check required dev size for TEST_DEV Yi Zhang
2022-11-02 2:57 ` Yi Zhang [this message]
2022-11-02 5:43 ` [PATCH V2 blktests 0/3] fix and improvement for xfs log size change from new xfsprogs version Chaitanya Kulkarni
2022-11-04 11:42 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102025702.1664101-4-yi.zhang@redhat.com \
--to=yi.zhang@redhat.com \
--cc=chaitanyak@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).