Re: [PATCH 1/3] blk-crypto: pass a gendisk to blk_crypto_sysfs_register

Christoph Hellwig
2022-11-09T12:49:59Z

On Mon, Nov 07, 2022 at 11:55:24AM -0800, Eric Biggers wrote:
> >
> > -int blk_crypto_sysfs_register(struct request_queue *q);
> > +int blk_crypto_sysfs_register(struct gendisk *disk);
> >
> > void blk_crypto_sysfs_unregister(struct request_queue *q);
>
> Shouldn't blk_crypto_sysfs_unregister() be updated to match?

While not strictly required, that would keep the interface symmetric,
so yes.