From: Christoph Hellwig <hch@lst.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/3] blk-crypto: pass a gendisk to blk_crypto_sysfs_register
Date: Wed, 9 Nov 2022 13:49:53 +0100 [thread overview]
Message-ID: <20221109124953.GB32628@lst.de> (raw)
In-Reply-To: <Y2lirLd1Gxs6+HEd@sol.localdomain>
On Mon, Nov 07, 2022 at 11:55:24AM -0800, Eric Biggers wrote:
> >
> > -int blk_crypto_sysfs_register(struct request_queue *q);
> > +int blk_crypto_sysfs_register(struct gendisk *disk);
> >
> > void blk_crypto_sysfs_unregister(struct request_queue *q);
>
> Shouldn't blk_crypto_sysfs_unregister() be updated to match?
While not strictly required, that would keep the interface symmetric,
so yes.
prev parent reply other threads:[~2022-11-09 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 8:08 [PATCH 1/3] blk-crypto: pass a gendisk to blk_crypto_sysfs_register Christoph Hellwig
2022-11-05 8:08 ` [PATCH 2/3] block: untangle request_queue refcounting from sysfs Christoph Hellwig
2022-11-07 19:57 ` Eric Biggers
2022-11-09 13:01 ` Christoph Hellwig
2022-11-05 8:08 ` [PATCH 3/3] block: mark blk_put_queue as potentially blocking Christoph Hellwig
2022-11-07 19:55 ` [PATCH 1/3] blk-crypto: pass a gendisk to blk_crypto_sysfs_register Eric Biggers
2022-11-09 12:49 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109124953.GB32628@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=ebiggers@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox