From: Alan Adamson <alan.adamson@oracle.com>
To: linux-block@vger.kernel.org
Cc: alan.adamson@oracle.com, linux-nvme@lists.infradead.org,
shinichiro.kawasaki@wdc.com
Subject: [PATCH v2] tests/nvme/039: Remove passthrough command tests
Date: Wed, 16 Nov 2022 14:39:45 -0800 [thread overview]
Message-ID: <20221116223945.1043785-1-alan.adamson@oracle.com> (raw)
Commit d7ac8dca938c ("nvme: quiet user passthrough command errors")
disabled error logging for passthrough commands so the associated
tests should be removed.
When an error logging opt-in mechanism for passthrough commands is
provided, the tests can be added back.
Signed-off-by: Alan Adamson <alan.adamson@oracle.com>
---
tests/nvme/039 | 3 ---
tests/nvme/039.out | 2 --
2 files changed, 5 deletions(-)
diff --git a/tests/nvme/039 b/tests/nvme/039
index e175055ddb06..11d6d24b6025 100755
--- a/tests/nvme/039
+++ b/tests/nvme/039
@@ -143,9 +143,6 @@ test_device() {
inject_invalid_status_on_read "${ns_dev}"
inject_write_fault_on_write "${ns_dev}"
- inject_access_denied_on_identify "${ctrl_dev}"
- inject_invalid_admin_cmd "${ctrl_dev}"
-
_nvme_err_inject_cleanup "${ns_dev}" "${ctrl_dev}"
echo "Test complete"
diff --git a/tests/nvme/039.out b/tests/nvme/039.out
index 162935eb1d7b..139070d22240 100644
--- a/tests/nvme/039.out
+++ b/tests/nvme/039.out
@@ -2,6 +2,4 @@ Running nvme/039
Read(0x2) @ LBA 0, 1 blocks, Unrecovered Read Error (sct 0x2 / sc 0x81) DNR
Read(0x2) @ LBA 0, 1 blocks, Unknown (sct 0x3 / sc 0x75) DNR
Write(0x1) @ LBA 0, 1 blocks, Write Fault (sct 0x2 / sc 0x80) DNR
- Identify(0x6), Access Denied (sct 0x2 / sc 0x86) DNR
- Unknown(0x96), Invalid Command Opcode (sct 0x0 / sc 0x1) DNR
Test complete
--
2.31.1
next reply other threads:[~2022-11-16 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 22:39 Alan Adamson [this message]
2022-11-17 6:50 ` [PATCH v2] tests/nvme/039: Remove passthrough command tests Chaitanya Kulkarni
2022-11-18 1:50 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116223945.1043785-1-alan.adamson@oracle.com \
--to=alan.adamson@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox