From: Christoph Hellwig <hch@lst.de>
To: Jinlong Chen <nickyc975@zju.edu.cn>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] elevator: restore old io scheduler on failure in elevator_switch
Date: Tue, 22 Nov 2022 13:24:46 +0100 [thread overview]
Message-ID: <20221122122446.GA5068@lst.de> (raw)
In-Reply-To: <6d74b4a9.5489.1849f42de2d.Coremail.nickyc975@zju.edu.cn>
On Tue, Nov 22, 2022 at 08:14:30PM +0800, Jinlong Chen wrote:
> Mostly failures specific to the intended io scheduler, like consuming more
> resources than the old one that the system can not afford. But sure it's
> rare, so do you think I should just correct the outdated document?
I'd be tempted to just documented the behavior, because I think the
chances are high that if switching to one schedule will fail that
switching back to the old one will fail as well. I've done a quick
audit of all three schedulers, and unless I missed something there
are no other failure cases except for running out of memory.
Maybe a printk to document that switching the scheduler failed are
we aren't using any scheduler now might be useful, though.
next prev parent reply other threads:[~2022-11-22 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 12:09 [RFC PATCH 0/2] elevator: restore old io scheduler on failure in elevator_switch Jinlong Chen
2022-11-18 12:09 ` [RFC PATCH 1/2] elevator: add a helper for applying scheduler to request_queue Jinlong Chen
2022-11-18 12:09 ` [RFC PATCH 2/2] elevator: restore the old io scheduler if failed to switch to the new one Jinlong Chen
2022-11-21 7:13 ` [RFC PATCH 0/2] elevator: restore old io scheduler on failure in elevator_switch Christoph Hellwig
2022-11-22 12:14 ` Jinlong Chen
2022-11-22 12:24 ` Christoph Hellwig [this message]
2022-11-22 12:44 ` Jinlong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122122446.GA5068@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickyc975@zju.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).