From: Eric Blake <eblake@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
josef@toxicpanda.com, linux-block@vger.kernel.org,
nbd@other.debian.org
Subject: Re: nbd: please don't spawn 16 threads when nbd is not even in use
Date: Wed, 23 Nov 2022 14:09:31 -0600 [thread overview]
Message-ID: <20221123200845.cuct5euvikqksojm@redhat.com> (raw)
In-Reply-To: <Y3y4+QqOlF00X9ET@duo.ucw.cz>
On Tue, Nov 22, 2022 at 12:56:41PM +0100, Pavel Machek wrote:
> Hi!
>
> I see this... and it looks like there are 16 workqueues before nbd is
> even used. Surely there are better ways to do that?
Yes, it would be nice to create a pool of workers that only spawns up
threads when actual parallel requests are made. Are you willing to
help write the patch?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-11-23 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 11:56 nbd: please don't spawn 16 threads when nbd is not even in use Pavel Machek
2022-11-23 20:09 ` Eric Blake [this message]
2022-11-23 22:01 ` Pavel Machek
2022-11-24 1:17 ` Yu Kuai
2022-11-24 10:06 ` Pavel Machek
2022-11-24 11:17 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123200845.cuct5euvikqksojm@redhat.com \
--to=eblake@redhat.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox