From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"damien.lemoal@opensource.wdc.com"
<damien.lemoal@opensource.wdc.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"vincent.fu@samsung.com" <vincent.fu@samsung.com>
Subject: Re: [PATCH V4 3/8] null_blk: initialize cmd->bio in __alloc_cmd()
Date: Wed, 30 Nov 2022 08:01:37 +0000 [thread overview]
Message-ID: <20221130080137.r75sokfluvn4ootr@shindev> (raw)
In-Reply-To: <20221129232813.37968-4-kch@nvidia.com>
On Nov 29, 2022 / 15:28, Chaitanya Kulkarni wrote:
> The function __alloc_cmd() is responsible to allocate tag and
> initialize the different members of the null_cmd structure e.g.
> cmd->tag, cmd->error, and cmd->nq, Move only member bio that is initialized
> from alloc_cmd() into __alloc_cmd().
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Looks good to me.
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
--
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2022-11-30 8:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 23:28 [PATCH V4 0/7] null_blk: allow REQ_OP_WRITE_ZEROES and cleanup Chaitanya Kulkarni
2022-11-29 23:28 ` [PATCH V4 1/8] null_blk: allow REQ_OP_WRITE_ZEROES Chaitanya Kulkarni
2022-11-30 7:59 ` Shinichiro Kawasaki
2022-11-30 23:29 ` Chaitanya Kulkarni
2022-12-01 1:21 ` Shinichiro Kawasaki
2022-11-29 23:28 ` [PATCH V4 2/8] null_blk: code cleaup Chaitanya Kulkarni
2022-11-30 8:00 ` Shinichiro Kawasaki
2022-11-29 23:28 ` [PATCH V4 3/8] null_blk: initialize cmd->bio in __alloc_cmd() Chaitanya Kulkarni
2022-11-30 8:01 ` Shinichiro Kawasaki [this message]
2022-11-29 23:28 ` [PATCH V4 4/8] null_blk: don't use magic numbers in the code Chaitanya Kulkarni
2022-11-29 23:28 ` [PATCH V4 5/8] null_blk: remove extra space in switch condition Chaitanya Kulkarni
2022-11-29 23:28 ` [PATCH V4 6/8] null_blk: add param to set max disacrd sectors Chaitanya Kulkarni
2022-11-30 8:07 ` Shinichiro Kawasaki
2022-11-29 23:28 ` [PATCH V4 7/8] null_blk: add param to set max write-zeroes sects Chaitanya Kulkarni
2022-11-30 8:09 ` Shinichiro Kawasaki
2022-11-29 23:28 ` [PATCH V4 8/8] null-blk: allow REQ_OP_ZONE_RESET_ALL to configure Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130080137.r75sokfluvn4ootr@shindev \
--to=shinichiro.kawasaki@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox