From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alvaro Karsz <alvaro.karsz@solid-run.com>,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
Date: Wed, 7 Dec 2022 05:21:48 -0500 [thread overview]
Message-ID: <20221207052001-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <Y5BCQ/9/uhXdu35W@infradead.org>
On Tue, Dec 06, 2022 at 11:35:31PM -0800, Christoph Hellwig wrote:
> This just seems like a horrible interface. And virtio-blk should be
> a simple passthrough and not grow tons of side-band crap like this.
>
> If you want to pass through random misc information use virtio-scsi
> or nvme with shadow doorbell buffers.
Christoph you acked the spec patch adding this to virtio blk:
Still not a fan of the encoding, but at least it is properly documented
now:
Acked-by: Christoph Hellwig <hch@lst.de>
Did you change your mind then? Or do you prefer a different encoding for
the ioctl then? could you help sugesting what kind?
Thanks,
--
MST
next prev parent reply other threads:[~2022-12-07 10:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 16:20 [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support Alvaro Karsz
2022-12-05 18:24 ` Jens Axboe
2022-12-05 18:36 ` Alvaro Karsz
2022-12-05 18:53 ` Jens Axboe
2022-12-05 20:29 ` Michael S. Tsirkin
2022-12-05 20:35 ` Enrico Granata
2022-12-05 23:09 ` Chaitanya Kulkarni
2022-12-05 20:36 ` Jens Axboe
2022-12-05 22:28 ` Chaitanya Kulkarni
2022-12-05 18:25 ` Jens Axboe
2022-12-06 16:31 ` Stefan Hajnoczi
2022-12-06 16:40 ` Michael S. Tsirkin
2022-12-06 18:25 ` Alvaro Karsz
2022-12-06 18:43 ` Bart Van Assche
2022-12-06 19:56 ` Alvaro Karsz
2022-12-07 3:32 ` Chaitanya Kulkarni
2022-12-07 7:35 ` Christoph Hellwig
2022-12-07 10:21 ` Michael S. Tsirkin [this message]
2022-12-07 16:31 ` Christoph Hellwig
2022-12-07 20:28 ` Michael S. Tsirkin
2022-12-11 9:49 ` Alvaro Karsz
2022-12-13 4:59 ` Chaitanya Kulkarni
2022-12-13 4:58 ` Chaitanya Kulkarni
2022-12-13 6:23 ` Michael S. Tsirkin
2022-12-19 7:59 ` Michael S. Tsirkin
2022-12-19 8:39 ` Alvaro Karsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207052001-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).