* [PATCH] virtio_blk: temporary variable type tweak
@ 2022-12-20 12:41 Michael S. Tsirkin
2022-12-20 19:51 ` Stefan Hajnoczi
2022-12-20 22:56 ` Chaitanya Kulkarni
0 siblings, 2 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2022-12-20 12:41 UTC (permalink / raw)
To: linux-kernel
Cc: Jason Wang, Paolo Bonzini, Stefan Hajnoczi, Jens Axboe,
virtualization, linux-block
virtblk_result returns blk_status_t which is a bitwise restricted type,
so we are not supposed to stuff it in a plain int temporary variable.
All we do with it is pass it on to a function expecting blk_status_t so
the generated code is ok, but we get warnings from sparse:
drivers/block/virtio_blk.c:326:36: sparse: sparse: incorrect type in initializer (different base types) @@ expected int status @@
+got restricted blk_status_t @@
drivers/block/virtio_blk.c:334:33: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted
+blk_status_t [usertype] error @@ got int status @@
Make sparse happy by using the correct type.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/block/virtio_blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 88d8410ecc5e..73cd5db0d7d5 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -336,7 +336,7 @@ static blk_status_t virtblk_setup_cmd(struct virtio_device *vdev,
static inline void virtblk_request_done(struct request *req)
{
struct virtblk_req *vbr = blk_mq_rq_to_pdu(req);
- int status = virtblk_result(vbr->status);
+ blk_status_t status = virtblk_result(vbr->status);
virtblk_unmap_data(req, vbr);
virtblk_cleanup_cmd(req);
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio_blk: temporary variable type tweak
2022-12-20 12:41 [PATCH] virtio_blk: temporary variable type tweak Michael S. Tsirkin
@ 2022-12-20 19:51 ` Stefan Hajnoczi
2022-12-20 22:56 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2022-12-20 19:51 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Jason Wang, Paolo Bonzini, Jens Axboe,
virtualization, linux-block
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On Tue, Dec 20, 2022 at 07:41:53AM -0500, Michael S. Tsirkin wrote:
> virtblk_result returns blk_status_t which is a bitwise restricted type,
> so we are not supposed to stuff it in a plain int temporary variable.
> All we do with it is pass it on to a function expecting blk_status_t so
> the generated code is ok, but we get warnings from sparse:
>
> drivers/block/virtio_blk.c:326:36: sparse: sparse: incorrect type in initializer (different base types) @@ expected int status @@
> +got restricted blk_status_t @@
> drivers/block/virtio_blk.c:334:33: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted
> +blk_status_t [usertype] error @@ got int status @@
>
> Make sparse happy by using the correct type.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/block/virtio_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio_blk: temporary variable type tweak
2022-12-20 12:41 [PATCH] virtio_blk: temporary variable type tweak Michael S. Tsirkin
2022-12-20 19:51 ` Stefan Hajnoczi
@ 2022-12-20 22:56 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2022-12-20 22:56 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel@vger.kernel.org
Cc: Jens Axboe, virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, Stefan Hajnoczi, Paolo Bonzini
On 12/20/22 04:41, Michael S. Tsirkin wrote:
> virtblk_result returns blk_status_t which is a bitwise restricted type,
> so we are not supposed to stuff it in a plain int temporary variable.
> All we do with it is pass it on to a function expecting blk_status_t so
> the generated code is ok, but we get warnings from sparse:
>
> drivers/block/virtio_blk.c:326:36: sparse: sparse: incorrect type in initializer (different base types) @@ expected int status @@
> +got restricted blk_status_t @@
> drivers/block/virtio_blk.c:334:33: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted
> +blk_status_t [usertype] error @@ got int status @@
>
> Make sparse happy by using the correct type.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-20 22:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-20 12:41 [PATCH] virtio_blk: temporary variable type tweak Michael S. Tsirkin
2022-12-20 19:51 ` Stefan Hajnoczi
2022-12-20 22:56 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).