* [PATCH] virtio_blk: zone append in header type tweak
@ 2022-12-20 12:52 Michael S. Tsirkin
2022-12-20 19:51 ` Stefan Hajnoczi
2022-12-20 22:56 ` Chaitanya Kulkarni
0 siblings, 2 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2022-12-20 12:52 UTC (permalink / raw)
To: linux-kernel
Cc: Jason Wang, Paolo Bonzini, Stefan Hajnoczi, Jens Axboe,
virtualization, linux-block
virtio blk returns a 64 bit append_sector in an input buffer,
in LE format. This field is not tagged as LE correctly, so
even though the generated code is ok, we get warnings from sparse:
drivers/block/virtio_blk.c:332:33: sparse: sparse: cast to restricted __le64
Make sparse happy by using the correct type.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/block/virtio_blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 73cd5db0d7d5..dc577e8bfa30 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -104,7 +104,7 @@ struct virtblk_req {
struct {
u8 status;
u8 reserved[7];
- u64 append_sector;
+ __le64 append_sector;
} zone_append_in_hdr;
};
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] virtio_blk: zone append in header type tweak
2022-12-20 12:52 [PATCH] virtio_blk: zone append in header type tweak Michael S. Tsirkin
@ 2022-12-20 19:51 ` Stefan Hajnoczi
2022-12-20 22:56 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2022-12-20 19:51 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Jason Wang, Paolo Bonzini, Jens Axboe,
virtualization, linux-block
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
On Tue, Dec 20, 2022 at 07:52:01AM -0500, Michael S. Tsirkin wrote:
> virtio blk returns a 64 bit append_sector in an input buffer,
> in LE format. This field is not tagged as LE correctly, so
> even though the generated code is ok, we get warnings from sparse:
>
> drivers/block/virtio_blk.c:332:33: sparse: sparse: cast to restricted __le64
>
> Make sparse happy by using the correct type.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/block/virtio_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio_blk: zone append in header type tweak
2022-12-20 12:52 [PATCH] virtio_blk: zone append in header type tweak Michael S. Tsirkin
2022-12-20 19:51 ` Stefan Hajnoczi
@ 2022-12-20 22:56 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2022-12-20 22:56 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel@vger.kernel.org
Cc: Jens Axboe, virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, Stefan Hajnoczi, Paolo Bonzini
On 12/20/22 04:52, Michael S. Tsirkin wrote:
> virtio blk returns a 64 bit append_sector in an input buffer,
> in LE format. This field is not tagged as LE correctly, so
> even though the generated code is ok, we get warnings from sparse:
>
> drivers/block/virtio_blk.c:332:33: sparse: sparse: cast to restricted __le64
>
> Make sparse happy by using the correct type.
>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-20 22:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-20 12:52 [PATCH] virtio_blk: zone append in header type tweak Michael S. Tsirkin
2022-12-20 19:51 ` Stefan Hajnoczi
2022-12-20 22:56 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).