From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk, hch@lst.de,
martin.petersen@oracle.com,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv3 1/2] block: make BLK_DEF_MAX_SECTORS unsigned
Date: Wed, 28 Dec 2022 16:53:17 +0100 [thread overview]
Message-ID: <20221228155317.GB388@lst.de> (raw)
In-Reply-To: <20221227191009.2277326-1-kbusch@meta.com>
> enum blk_default_limits {
> BLK_MAX_SEGMENTS = 128,
> BLK_SAFE_MAX_SECTORS = 255,
> - BLK_DEF_MAX_SECTORS = 2560,
> BLK_MAX_SEGMENT_SIZE = 65536,
> BLK_SEG_BOUNDARY_MASK = 0xFFFFFFFFUL,
> };
Looking at the enum all these really should be unsigned values anyway,
so we might as well keep the enum.
Either way this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2022-12-28 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 19:10 [PATCHv3 1/2] block: make BLK_DEF_MAX_SECTORS unsigned Keith Busch
2022-12-27 19:10 ` [PATCHv3 2/2] block: save user max_sectors limit Keith Busch
[not found] ` <202212280931.RDVmPBnX-lkp@intel.com>
2022-12-28 15:51 ` Christoph Hellwig
2022-12-28 16:06 ` Keith Busch
2022-12-28 15:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221228155317.GB388@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox