From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0CDC3DA7A for ; Mon, 2 Jan 2023 15:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233001AbjABPOR (ORCPT ); Mon, 2 Jan 2023 10:14:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236369AbjABPOP (ORCPT ); Mon, 2 Jan 2023 10:14:15 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CACC9C05; Mon, 2 Jan 2023 07:14:14 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 87D025C228; Mon, 2 Jan 2023 15:14:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1672672453; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lVb30ysuSqkubuaZ/v0LpSOwkrc62XCDm7CmyzbF9LA=; b=N4LN2Rg5AeTwhfiasZnJYxrKN3+cn9fv2ZEWw1CeeYdsYWQCqLx4Nq5oObVEccMYX6ZPNC Y57UIE1hD8EnZvNweZ7V//wvpPwl9x/Ic5nmm6RDL+SjN92LBQ73wpv9bJTVTjHJpvYf6R JGLIY0BU/3RLGnoHSw5EKYL3fKSPRPM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1672672453; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lVb30ysuSqkubuaZ/v0LpSOwkrc62XCDm7CmyzbF9LA=; b=bQglcq0GBgrnIPXpWk6Q8ZdutYipdLVY8JXxH1o7DNUYbHIpJ3esq/KdSRVJM/R2Nf318A UjknlqIAIpH7VIBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6B19413427; Mon, 2 Jan 2023 15:14:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oWcWGsX0smNNYgAAMHmgww (envelope-from ); Mon, 02 Jan 2023 15:14:13 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 8A873A073E; Mon, 2 Jan 2023 16:14:11 +0100 (CET) Date: Mon, 2 Jan 2023 16:14:11 +0100 From: Jan Kara To: Kemeng Shi Cc: paolo.valente@linaro.org, axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, jack@suse.cz, hch@lst.de, damien.lemoal@wdc.com Subject: Re: [PATCH RESEND v2 02/10] block, bfq: remove unsed parameter reason in bfq_bfqq_is_slow Message-ID: <20230102151411.4lhfygpckczyqtp7@quack3> References: <20221222191641.1643117-1-shikemeng@huaweicloud.com> <20221222191641.1643117-3-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221222191641.1643117-3-shikemeng@huaweicloud.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri 23-12-22 03:16:33, Kemeng Shi wrote: > Parameter reason is never used, just remove it. > > Signed-off-by: Kemeng Shi Sure. Feel free to add: Reviewed-by: Jan Kara Honza > --- > block/bfq-iosched.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c > index 1220c41fc767..5a6d9e8c329d 100644 > --- a/block/bfq-iosched.c > +++ b/block/bfq-iosched.c > @@ -4066,8 +4066,7 @@ static void __bfq_bfqq_recalc_budget(struct bfq_data *bfqd, > * function to evaluate the I/O speed of a process. > */ > static bool bfq_bfqq_is_slow(struct bfq_data *bfqd, struct bfq_queue *bfqq, > - bool compensate, enum bfqq_expiration reason, > - unsigned long *delta_ms) > + bool compensate, unsigned long *delta_ms) > { > ktime_t delta_ktime; > u32 delta_usecs; > @@ -4263,7 +4262,7 @@ void bfq_bfqq_expire(struct bfq_data *bfqd, > /* > * Check whether the process is slow (see bfq_bfqq_is_slow). > */ > - slow = bfq_bfqq_is_slow(bfqd, bfqq, compensate, reason, &delta); > + slow = bfq_bfqq_is_slow(bfqd, bfqq, compensate, &delta); > > /* > * As above explained, charge slow (typically seeky) and > -- > 2.30.0 > -- Jan Kara SUSE Labs, CR