From: Christoph Hellwig <hch@lst.de>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: axboe@kernel.dk, dwagner@suse.de, hare@suse.de,
ming.lei@redhat.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, hch@lst.de, john.garry@huawei.com,
jack@suse.cz
Subject: Re: [PATCH v2 07/13] blk-mq: remove error count and unncessary flush in blk_mq_try_issue_list_directly
Date: Sun, 8 Jan 2023 19:03:01 +0100 [thread overview]
Message-ID: <20230108180300.GF23466@lst.de> (raw)
In-Reply-To: <20230104142259.2673013-8-shikemeng@huaweicloud.com>
Similar comment as for the previous patch, just complicated by the
excursion to blk_mq_request_bypass_insert.
next prev parent reply other threads:[~2023-01-08 18:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 14:22 [PATCH v2 00/13] A few bugfix and cleanup patches for blk-mq Kemeng Shi
2023-01-04 14:22 ` [PATCH v2 01/13] blk-mq: avoid sleep in blk_mq_alloc_request_hctx Kemeng Shi
2023-01-08 17:55 ` Christoph Hellwig
2023-01-04 14:22 ` [PATCH v2 02/13] blk-mq: remove stale comment for blk_mq_sched_mark_restart_hctx Kemeng Shi
2023-01-08 17:55 ` Christoph Hellwig
2023-01-04 14:22 ` [PATCH v2 03/13] blk-mq: wait on correct sbitmap_queue in blk_mq_mark_tag_wait Kemeng Shi
2023-01-08 17:55 ` Christoph Hellwig
2023-01-04 14:22 ` [PATCH v2 04/13] blk-mq: Fix potential io hung for shared sbitmap per tagset Kemeng Shi
2023-01-04 14:22 ` [PATCH v2 05/13] blk-mq: remove unnecessary list_empty check in blk_mq_try_issue_list_directly Kemeng Shi
2023-01-08 17:56 ` Christoph Hellwig
2023-01-04 14:22 ` [PATCH v2 06/13] blk-mq: remove unncessary error count and flush in blk_mq_plug_issue_direct Kemeng Shi
2023-01-08 18:02 ` Christoph Hellwig
2023-01-04 14:22 ` [PATCH v2 07/13] blk-mq: remove error count and unncessary flush in blk_mq_try_issue_list_directly Kemeng Shi
2023-01-08 18:03 ` Christoph Hellwig [this message]
2023-01-04 14:22 ` [PATCH v2 08/13] blk-mq: simplify flush check in blk_mq_dispatch_rq_list Kemeng Shi
2023-01-08 18:06 ` Christoph Hellwig
2023-01-09 2:27 ` Kemeng Shi
2023-01-10 8:09 ` Christoph Hellwig
2023-01-10 12:35 ` Kemeng Shi
2023-01-04 14:22 ` [PATCH v2 09/13] blk-mq: remove unnecessary error count and " Kemeng Shi
2023-01-04 14:22 ` [PATCH v2 10/13] blk-mq: remove set of bd->last when get driver tag for next request fails Kemeng Shi
2023-01-04 14:22 ` [PATCH v2 11/13] blk-mq: remove unncessary from_schedule parameter in blk_mq_plug_issue_direct Kemeng Shi
2023-01-08 18:06 ` Christoph Hellwig
2023-01-04 14:22 ` [PATCH v2 12/13] blk-mq: use switch/case to improve readability in blk_mq_try_issue_list_directly Kemeng Shi
2023-01-04 14:22 ` [PATCH v2 13/13] blk-mq: correct stale comment of .get_budget Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108180300.GF23466@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shikemeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).