From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0951DC00A5A for ; Thu, 19 Jan 2023 17:05:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229969AbjASRFc (ORCPT ); Thu, 19 Jan 2023 12:05:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229885AbjASRFa (ORCPT ); Thu, 19 Jan 2023 12:05:30 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D225A5CB; Thu, 19 Jan 2023 09:05:30 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id B13F968D0D; Thu, 19 Jan 2023 18:05:26 +0100 (CET) Date: Thu, 19 Jan 2023 18:05:26 +0100 From: Christoph Hellwig To: Tejun Heo Cc: Christoph Hellwig , Jens Axboe , Josef Bacik , linux-block@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: switch blk-cgroup to work on gendisk Message-ID: <20230119170526.GA5050@lst.de> References: <20230117081257.3089859-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jan 19, 2023 at 07:03:31AM -1000, Tejun Heo wrote: > On Tue, Jan 17, 2023 at 09:12:42AM +0100, Christoph Hellwig wrote: > > blk-cgroup works on only on live disks and "file system" I/O from bios. > > This all the information should be in the gendisk, and not the > > request_queue that also exists for pure passthrough request based > > devices. > > Can't blk-throttle be used w/ bio based ones tho? I always thought that was > the reason why we didn't move it into rq-qos framework. Yes, it can. Not sure if my sentence was unclear, but: - everything doing non-passthrough I/O only should be in the gendisk - everything related to blk-mq, including infrastruture for passthrough should remain in the request_queue The idea that the request_queue will eventually become a blk-mq only data structure and not exist (or just have a very leight weight stub) for bio based drivers.