* [PATCH] block: Fix the blk_mq_destroy_queue() documentation
@ 2023-01-30 21:12 Bart Van Assche
2023-01-31 8:54 ` Christoph Hellwig
2023-01-31 18:46 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Bart Van Assche @ 2023-01-30 21:12 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, Bart Van Assche, Christoph Hellwig, Sagi Grimberg,
Chaitanya Kulkarni, Keith Busch
Commit 2b3f056f72e5 moved a blk_put_queue() call from
blk_mq_destroy_queue() into its callers. Reflect this change in the
documentation block above blk_mq_destroy_queue().
Cc: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Chaitanya Kulkarni <kch@nvidia.com>
Cc: Keith Busch <kbusch@kernel.org>
Fixes: 2b3f056f72e5 ("blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/blk-mq.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 9d463f7563bc..9c8dc70020bc 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -4069,8 +4069,9 @@ EXPORT_SYMBOL(blk_mq_init_queue);
* blk_mq_destroy_queue - shutdown a request queue
* @q: request queue to shutdown
*
- * This shuts down a request queue allocated by blk_mq_init_queue() and drops
- * the initial reference. All future requests will failed with -ENODEV.
+ * This shuts down a request queue allocated by blk_mq_init_queue(). All future
+ * requests will be failed with -ENODEV. The caller is responsible for dropping
+ * the reference from blk_mq_init_queue() by calling blk_put_queue().
*
* Context: can sleep
*/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Fix the blk_mq_destroy_queue() documentation
2023-01-30 21:12 [PATCH] block: Fix the blk_mq_destroy_queue() documentation Bart Van Assche
@ 2023-01-31 8:54 ` Christoph Hellwig
2023-01-31 18:46 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2023-01-31 8:54 UTC (permalink / raw)
To: Bart Van Assche
Cc: Jens Axboe, linux-block, Christoph Hellwig, Sagi Grimberg,
Chaitanya Kulkarni, Keith Busch
On Mon, Jan 30, 2023 at 01:12:33PM -0800, Bart Van Assche wrote:
> Commit 2b3f056f72e5 moved a blk_put_queue() call from
> blk_mq_destroy_queue() into its callers. Reflect this change in the
> documentation block above blk_mq_destroy_queue().
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Fix the blk_mq_destroy_queue() documentation
2023-01-30 21:12 [PATCH] block: Fix the blk_mq_destroy_queue() documentation Bart Van Assche
2023-01-31 8:54 ` Christoph Hellwig
@ 2023-01-31 18:46 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2023-01-31 18:46 UTC (permalink / raw)
To: Bart Van Assche
Cc: linux-block, Christoph Hellwig, Sagi Grimberg, Chaitanya Kulkarni,
Keith Busch
On Mon, 30 Jan 2023 13:12:33 -0800, Bart Van Assche wrote:
> Commit 2b3f056f72e5 moved a blk_put_queue() call from
> blk_mq_destroy_queue() into its callers. Reflect this change in the
> documentation block above blk_mq_destroy_queue().
>
>
Applied, thanks!
[1/1] block: Fix the blk_mq_destroy_queue() documentation
commit: 81ea42b9c3d61ea34d82d900ed93f4b4851f13b0
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-31 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-30 21:12 [PATCH] block: Fix the blk_mq_destroy_queue() documentation Bart Van Assche
2023-01-31 8:54 ` Christoph Hellwig
2023-01-31 18:46 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).