From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-block-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B415DC636D4
	for <linux-block@archiver.kernel.org>; Wed,  8 Feb 2023 06:35:58 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229781AbjBHGf5 (ORCPT <rfc822;linux-block@archiver.kernel.org>);
        Wed, 8 Feb 2023 01:35:57 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57520 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229805AbjBHGf4 (ORCPT
        <rfc822;linux-block@vger.kernel.org>); Wed, 8 Feb 2023 01:35:56 -0500
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32CDC442C0;
        Tue,  7 Feb 2023 22:35:56 -0800 (PST)
Received: by verein.lst.de (Postfix, from userid 2407)
        id 6DFDB68BFE; Wed,  8 Feb 2023 07:35:52 +0100 (CET)
Date:   Wed, 8 Feb 2023 07:35:52 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
        linux-block@vger.kernel.org, cgroups@vger.kernel.org,
        Andreas Herrmann <aherrmann@suse.de>
Subject: Re: [PATCH 02/19] blk-cgroup: delay blk-cgroup initialization
 until add_disk
Message-ID: <20230208063552.GA15030@lst.de>
References: <20230201134123.2656505-1-hch@lst.de> <20230201134123.2656505-3-hch@lst.de> <Y+Ji4NL/WkTR8vml@T590>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+Ji4NL/WkTR8vml@T590>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-block.vger.kernel.org>
X-Mailing-List: linux-block@vger.kernel.org

On Tue, Feb 07, 2023 at 10:40:32PM +0800, Ming Lei wrote:
> because disk->root_blkg is freed & set as NULL in del_gendisk().
> 
> by the following script:
> 
> 	modprobe -r scsi_debug
> 	modprobe scsi_debug dev_size_mb=1024
> 	
> 	mkfs.xfs -f /dev/sdc	#suppose sdc is the scsi debug disk
> 	mount /dev/sdc /mnt
> 	echo 1 > /sys/block/sdc/device/delete
> 	sleep 1
> 	umount /mnt

Thank,

I've sent a fix.  Can you wire up your reproducer in blktests?