From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH blktests] nvme/046: add test for unprivileged passthrough
Date: Tue, 14 Feb 2023 04:57:07 +0000 [thread overview]
Message-ID: <20230214045707.sf7hu4b7hzgzbyns@shindev> (raw)
In-Reply-To: <20230210111212.GA17396@green5>
On Feb 10, 2023 / 16:42, Kanchan Joshi wrote:
> On Fri, Feb 10, 2023 at 02:01:14AM +0000, Shinichiro Kawasaki wrote:
[...]
> > If you don't mind, I can create another patch for further discussion based on
> > the suggestion above, and modify your patch to use the new helper functions.
> Sure. Please remove "_have_fio" line also in v2.
Okay. I've sent out v2 [1]. Please check and confirm that it works for you.
FYI, I did a couple of more nit edits:
- No need to call _require_test_dev_is_nvme, since it is called from
group_device_requires in tests/nvme/rc.
- Separated local variable declarations and initialization. ('make check'
reported shellcheck complaints about it.)
[1] https://lore.kernel.org/linux-block/20230214044739.1903364-1-shinichiro.kawasaki@wdc.com/
--
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2023-02-14 4:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230209094631epcas5p436d4f54caa91ff6d258928bba76206de@epcas5p4.samsung.com>
2023-02-09 9:45 ` [PATCH blktests] nvme/046: add test for unprivileged passthrough Kanchan Joshi
2023-02-09 16:22 ` kernel test robot
2023-02-10 2:01 ` Shinichiro Kawasaki
2023-02-10 11:12 ` Kanchan Joshi
2023-02-14 4:57 ` Shinichiro Kawasaki [this message]
2023-02-14 5:54 ` Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214045707.sf7hu4b7hzgzbyns@shindev \
--to=shinichiro.kawasaki@wdc.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox