From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 0/2] blktests: add mini ublk source and blktests/033
Date: Thu, 16 Feb 2023 08:35:20 +0000 [thread overview]
Message-ID: <20230216083519.w362iawzqweilzes@shindev> (raw)
In-Reply-To: <20230216030134.1368607-1-ming.lei@redhat.com>
On Feb 16, 2023 / 11:01, Ming Lei wrote:
> Hello,
>
> The 1st patch adds one mini ublk program, which only supports null &
> loop targets.
>
> The 2nd patch add blktests/033 for covering gendisk leak issue.
>
> Ming Lei (2):
> blktests/src: add mini ublk source code
> blktests/033: add test to cover gendisk leak
Hi Ming, thanks for the patches. Please find my comments on them.
Also, could you run "make check" for the blktests patches? Shellcheck reported
some warnings in the changes.
$ make check
shellcheck -x -e "" -f gcc check new common/* \
tests/*/rc tests/*/[0-9]*[0-9]
common/ublk:19:52: warning: args is referenced but not assigned. [SC2154]
tests/block/033:27:8: warning: Declare and assign separately to avoid masking return values. [SC2155]
tests/block/033:27:17: note: Use $(...) notation instead of legacy backticks `...`. [SC2006]
tests/block/033:28:24: note: Double quote to prevent globbing and word splitting. [SC2086]
--
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2023-02-16 8:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 3:01 [PATCH 0/2] blktests: add mini ublk source and blktests/033 Ming Lei
2023-02-16 3:01 ` [PATCH 1/2] blktests/src: add mini ublk source code Ming Lei
2023-02-16 8:19 ` Shinichiro Kawasaki
2023-02-16 8:58 ` Ming Lei
2023-02-16 11:10 ` Ming Lei
2023-02-16 11:53 ` Shinichiro Kawasaki
2023-02-16 3:01 ` [PATCH 2/2] blktests/033: add test to cover gendisk leak Ming Lei
2023-02-16 8:29 ` Shinichiro Kawasaki
2023-02-16 9:02 ` Ming Lei
2023-02-16 8:35 ` Shinichiro Kawasaki [this message]
2023-02-16 9:05 ` [PATCH 0/2] blktests: add mini ublk source and blktests/033 Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216083519.w362iawzqweilzes@shindev \
--to=shinichiro.kawasaki@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox