From: Thomas Huth <thuth@redhat.com>
To: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, Chas Williams <3chas3@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
Andrew Waterman <waterman@eecs.berkeley.edu>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: [PATCH 4/4] Move USE_WCACHING to drivers/block/pktcdvd.c
Date: Fri, 17 Feb 2023 21:23:01 +0100 [thread overview]
Message-ID: <20230217202301.436895-5-thuth@redhat.com> (raw)
In-Reply-To: <20230217202301.436895-1-thuth@redhat.com>
From: Palmer Dabbelt <palmer@dabbelt.com>
I don't think this was ever intended to be exposed to userspace, but
it did require an "#ifdef CONFIG_*". Since the name is kind of
generic and was only used in one place, I've moved the definition to
the one user.
Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
Reviewed-by: Andrew Waterman <waterman@eecs.berkeley.edu>
Reviewed-by: Albert Ou <aou@eecs.berkeley.edu>
Message-Id: <1447119071-19392-11-git-send-email-palmer@dabbelt.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
drivers/block/pktcdvd.c | 11 +++++++++++
include/uapi/linux/pktcdvd.h | 11 -----------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 2f1a92509271..1d5ec8d9d1a5 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -90,6 +90,17 @@ do { \
#define MAX_SPEED 0xffff
+/*
+ * use drive write caching -- we need deferred error handling to be
+ * able to successfully recover with this option (drive will return good
+ * status as soon as the cdb is validated).
+ */
+#if defined(CONFIG_CDROM_PKTCDVD_WCACHE)
+#define USE_WCACHING 1
+#else
+#define USE_WCACHING 0
+#endif
+
static DEFINE_MUTEX(pktcdvd_mutex);
static struct pktcdvd_device *pkt_devs[MAX_WRITERS];
static struct proc_dir_entry *pkt_proc;
diff --git a/include/uapi/linux/pktcdvd.h b/include/uapi/linux/pktcdvd.h
index 9cbb55d21c94..6a5552dfd6af 100644
--- a/include/uapi/linux/pktcdvd.h
+++ b/include/uapi/linux/pktcdvd.h
@@ -29,17 +29,6 @@
*/
#define PACKET_WAIT_TIME (HZ * 5 / 1000)
-/*
- * use drive write caching -- we need deferred error handling to be
- * able to successfully recover with this option (drive will return good
- * status as soon as the cdb is validated).
- */
-#if defined(CONFIG_CDROM_PKTCDVD_WCACHE)
-#define USE_WCACHING 1
-#else
-#define USE_WCACHING 0
-#endif
-
/*
* No user-servicable parts beyond this point ->
*/
--
2.31.1
next prev parent reply other threads:[~2023-02-17 20:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 20:22 [PATCH 0/4] Remove #ifdef CONFIG_* from uapi headers (2023 edition) Thomas Huth
2023-02-17 20:22 ` [PATCH 1/4] Move COMPAT_ATM_ADDPARTY to net/atm/svc.c Thomas Huth
2023-02-20 6:14 ` Christoph Hellwig
2023-02-17 20:22 ` [PATCH 2/4] Move ep_take_care_of_epollwakeup() to fs/eventpoll.c Thomas Huth
2023-02-17 20:57 ` Arnd Bergmann
2023-02-20 6:15 ` Christoph Hellwig
2023-02-17 20:23 ` [PATCH 3/4] Move bp_type_idx to include/linux/hw_breakpoint.h Thomas Huth
2023-02-17 21:01 ` Arnd Bergmann
2023-02-20 6:15 ` Christoph Hellwig
2023-02-17 20:23 ` Thomas Huth [this message]
2023-02-17 21:08 ` [PATCH 4/4] Move USE_WCACHING to drivers/block/pktcdvd.c Arnd Bergmann
2023-02-20 6:20 ` Christoph Hellwig
2023-02-17 21:11 ` [PATCH 0/4] Remove #ifdef CONFIG_* from uapi headers (2023 edition) Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217202301.436895-5-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=3chas3@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=waterman@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).