From: Pankaj Raghav <p.raghav@samsung.com>
To: Juhyung Park <qkrwngud825@gmail.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH v2] block: remove more NULL checks after bdev_get_queue()
Date: Mon, 20 Feb 2023 17:29:11 +0530 [thread overview]
Message-ID: <20230220115911.2lmxkmietqqywpwp@quentin> (raw)
In-Reply-To: <20230203024029.48260-1-qkrwngud825@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
On Fri, Feb 03, 2023 at 11:40:29AM +0900, Juhyung Park wrote:
> bdev_get_queue() never returns NULL. Several commits [1][2] have been made
> before to remove such superfluous checks, but some still remained.
>
> For places where bdev_get_queue() is called solely for NULL checks, it is
> removed entirely.
>
> [1] commit ec9fd2a13d74 ("blk-lib: don't check bdev_get_queue() NULL check")
> [2] commit fea127b36c93 ("block: remove superfluous check for request queue in bdev_is_zoned()")
>
> Signed-off-by: Juhyung Park <qkrwngud825@gmail.com>
Looks good,
Reviewed-by: Pankaj Raghav <p.raghav@samsung.com>
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2023-02-20 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230220115915eucas1p164d1b65b3cb0b140468af33e0f966807@eucas1p1.samsung.com>
2023-02-03 2:40 ` [PATCH v2] block: remove more NULL checks after bdev_get_queue() Juhyung Park
2023-02-19 20:42 ` Juhyung Park
2023-02-20 11:59 ` Pankaj Raghav [this message]
2023-02-22 16:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220115911.2lmxkmietqqywpwp@quentin \
--to=p.raghav@samsung.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=qkrwngud825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox