Linux block layer
 help / color / mirror / Atom feed
From: Pankaj Raghav <p.raghav@samsung.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
	Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [PATCH 2/2] block: null_blk: cleanup null_queue_rq()
Date: Tue, 14 Mar 2023 10:51:22 +0100	[thread overview]
Message-ID: <20230314095122.jrfkyvdy2yyhupwp@blixen> (raw)
In-Reply-To: <20230314041106.19173-3-damien.lemoal@opensource.wdc.com>

On Tue, Mar 14, 2023 at 01:11:06PM +0900, Damien Le Moal wrote:
> Use a local struct request pointer variable to avoid having to
> dereference struct blk_mq_queue_data multiple times. While at it, also
> fix the function argument indentation and remove a useless "else" after
> a return.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
>  drivers/block/null_blk/main.c | 29 ++++++++++++++---------------
>  1 file changed, 14 insertions(+), 15 deletions(-)

Looks good,
Reviewed-by: Pankaj Raghav <p.raghav@samsung.com>

  reply	other threads:[~2023-03-14  9:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14  4:11 [PATCH 0/2] null_blk fix and cleanup Damien Le Moal
2023-03-14  4:11 ` [PATCH 1/2] block: null_blk: Fix handling of fake timeout request Damien Le Moal
2023-03-15  8:54   ` Johannes Thumshirn
2023-03-14  4:11 ` [PATCH 2/2] block: null_blk: cleanup null_queue_rq() Damien Le Moal
2023-03-14  9:51   ` Pankaj Raghav [this message]
2023-03-15  8:53   ` Johannes Thumshirn
2023-03-15 12:51 ` [PATCH 0/2] null_blk fix and cleanup Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314095122.jrfkyvdy2yyhupwp@blixen \
    --to=p.raghav@samsung.com \
    --cc=akinobu.mita@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox