From: Alyssa Ross <hi@alyssa.is>
To: chaitanyak@nvidia.com,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: axboe@kernel.dk, hch@lst.de, hi@alyssa.is, linux-block@vger.kernel.org
Subject: [PATCH blktests] loop/009: add test for loop partition uvents
Date: Thu, 30 Mar 2023 16:02:47 +0000 [thread overview]
Message-ID: <20230330160247.16030-1-hi@alyssa.is> (raw)
In-Reply-To: <21c2861f-9b7d-636e-74e1-27bd7bbb1a4f@nvidia.com>
Link: https://lore.kernel.org/r/20230320125430.55367-1-hch@lst.de/
Suggested-by: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
tests/loop/009 | 62 ++++++++++++++++++++++++++++++++++++++++++++++
tests/loop/009.out | 3 +++
2 files changed, 65 insertions(+)
create mode 100755 tests/loop/009
create mode 100644 tests/loop/009.out
diff --git a/tests/loop/009 b/tests/loop/009
new file mode 100755
index 0000000..dfa9de3
--- /dev/null
+++ b/tests/loop/009
@@ -0,0 +1,62 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright 2023 Alyssa Ross
+#
+# Regression test for patch "loop: LOOP_CONFIGURE: send uevents for partitions".
+
+. tests/loop/rc
+
+DESCRIPTION="check that LOOP_CONFIGURE sends uevents for partitions"
+
+QUICK=1
+
+test() {
+ echo "Running ${TEST_NAME}"
+
+ # Make a disk image with a partition.
+ truncate -s 3MiB "$TMPDIR/img"
+ sfdisk "$TMPDIR/img" >"$FULL" <<EOF
+label: gpt
+size=1MiB
+EOF
+
+ mkfifo "$TMPDIR/mon"
+ timeout 5 udevadm monitor -ks block/partition >"$TMPDIR/mon" &
+
+ # Open the fifo for reading, and wait for udevadm monitor to start.
+ exec 3< "$TMPDIR/mon"
+ read -r _ <&3
+ read -r _ <&3
+ read -r _ <&3
+
+ dev="$(losetup -f)"
+
+ # The default udev behavior is to watch loop devices, which means that
+ # udevd will explicitly prompt the kernel to rescan the partitions with
+ # ioctl(BLKRRPART). We want to make sure we're getting uevents from
+ # ioctl(LOOP_CONFIGURE), so disable this udev behavior for our device to
+ # avoid false positives.
+ echo "ACTION!=\"remove\", KERNEL==\"${dev#/dev/}\", OPTIONS+=\"nowatch\"" \
+ >/run/udev/rules.d/99-blktests-$$.rules
+ udevadm control -R
+
+ # Open and close the loop device for writing, to trigger the inotify
+ # event udevd had already started listening for.
+ : > "$dev"
+
+ # Wait for udev to have processed the inotify event.
+ udevadm control --ping
+
+ losetup -P "$dev" "$TMPDIR/img"
+
+ # Wait for at most 1 add event so we don't need to wait for timeout if
+ # we get what we're looking for.
+ <&3 grep -m 1 '^KERNEL\[.*\] add' |
+ sed -e 's/\[.*\]//' -e 's/loop[0-9]\+/loop_/g'
+
+ rm /run/udev/rules.d/99-blktests-$$.rules
+ udevadm control -R
+ losetup -d "$dev"
+
+ echo "Test complete"
+}
diff --git a/tests/loop/009.out b/tests/loop/009.out
new file mode 100644
index 0000000..658dcff
--- /dev/null
+++ b/tests/loop/009.out
@@ -0,0 +1,3 @@
+Running loop/009
+KERNEL add /devices/virtual/block/loop_/loop_p1 (block)
+Test complete
--
2.37.1
next prev parent reply other threads:[~2023-03-30 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 12:54 [PATCH] loop: LOOP_CONFIGURE: send uevents for partitions Christoph Hellwig
2023-03-26 23:09 ` Chaitanya Kulkarni
2023-03-30 16:02 ` Alyssa Ross [this message]
2023-03-30 19:22 ` [PATCH blktests] loop/009: add test for loop partition uvents kernel test robot
2023-03-30 19:50 ` LKP kernel test robot and blktests patches Alyssa Ross
2023-03-31 15:26 ` Yujie Liu
2023-04-04 18:29 ` [PATCH blktests] loop/009: add test for loop partition uvents Chaitanya Kulkarni
2023-04-04 18:45 ` Alyssa Ross
2023-04-06 10:30 ` Shin'ichiro Kawasaki
2023-05-22 2:29 ` Shinichiro Kawasaki
2023-03-29 15:24 ` [PATCH] loop: LOOP_CONFIGURE: send uevents for partitions Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330160247.16030-1-hi@alyssa.is \
--to=hi@alyssa.is \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox