From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C460C76188 for ; Wed, 5 Apr 2023 08:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237151AbjDEIAw (ORCPT ); Wed, 5 Apr 2023 04:00:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236881AbjDEIAv (ORCPT ); Wed, 5 Apr 2023 04:00:51 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62D1230E2; Wed, 5 Apr 2023 01:00:50 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D0B2320600; Wed, 5 Apr 2023 08:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680681648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NF83qlVzxv5rP31TK87fQBjgypo+iPk8Tgc/ff/LzS0=; b=nWYAwbTopJSeJ+HfSY6AkXfF6hH7nbJMp50CUAQdErLnNegkaTgEgfo0Xtcp3Y0Zy6IYqu XsFYsercb9dhTAcnh9CiJLDMkcLllZsaGQ8D5uWxucNnpWOTOwS2i2ciWfvyLP63x+kb7Z f8bb2+A7sVt9W5n2EwOktFXUdweSbwk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 85D4013A10; Wed, 5 Apr 2023 08:00:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ai37H7AqLWQjMwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 08:00:48 +0000 Date: Wed, 5 Apr 2023 10:00:47 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, Michal Hocko Subject: Re: [PATCH v3 6/8] workingset: memcg: sleep when flushing stats in workingset_refault() Message-ID: <20230405080047.5omnatjbwz46f3y5@blackpad> References: <20230330191801.1967435-1-yosryahmed@google.com> <20230330191801.1967435-7-yosryahmed@google.com> <20230404165305.ffs7uscqpndnfytn@blackpad> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xkpos56pi67t66c5" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org --xkpos56pi67t66c5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 04, 2023 at 11:09:02AM -0700, Yosry Ahmed wrote: > IIUC there are multiple places where we can sleep in this path, we can > sleep waiting for a page to be read from disk, we can sleep during > allocating the page to read into, and IIUC the allocations on the > fault path can even run into reclaim, going into the vmscan code. So > there are precedents, but I am not sure if that's enough argument. I expect it'd depend on the proportion of the slow/fast paths. OK, let's see how it turns out in wider population. Thanks, Michal --xkpos56pi67t66c5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZC0qqwAKCRAkDQmsBEOq uQd1AP9da0usdZXtaqKldZWC3hNIo/w+tYQarhExM3TWXX+KGQEAvck6zPYNvKdu uhY4KtMQkxSOomI7xDc/A08Ae98OjA8= =ErRC -----END PGP SIGNATURE----- --xkpos56pi67t66c5--