Re: [PATCH 1/5] sed-opal: do not add user authority twice in boolean ace.

Christian Brauner
2023-03-29T14:16:54Z

On Wed, Mar 22, 2023 at 04:16:00PM +0100, Ondrej Kozina wrote:
> While adding user authority in boolean ace value
> of uid OPAL_LOCKINGRANGE_ACE_WRLOCKED or
> OPAL_LOCKINGRANGE_ACE_RDLOCKED, it was added twice.
>
> Signed-off-by: Ondrej Kozina <okozina@redhat.com>
> Tested-by: Luca Boccassi <bluca@debian.org>
> Tested-by: Milan Broz <gmazyland@gmail.com>
> ---
> block/sed-opal.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/block/sed-opal.c b/block/sed-opal.c
> index c320093c14f1..d86d3e5f5a44 100644
> --- a/block/sed-opal.c
> +++ b/block/sed-opal.c
> @@ -1798,22 +1798,6 @@ static int add_user_to_lr(struct opal_dev *dev, void *data)
> add_token_bytestring(&err, dev, user_uid, OPAL_UID_LENGTH);
> add_token_u8(&err, dev, OPAL_ENDNAME);
>
> -
> - add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_bytestring(&err, dev,
> - opaluid[OPAL_HALF_UID_AUTHORITY_OBJ_REF],
> - OPAL_UID_LENGTH/2);
> - add_token_bytestring(&err, dev, user_uid, OPAL_UID_LENGTH);
> - add_token_u8(&err, dev, OPAL_ENDNAME);
> -
> -
> - add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_bytestring(&err, dev, opaluid[OPAL_HALF_UID_BOOLEAN_ACE],

This index only appears one time in the code. IOW, you're completely
removing OPAL_HALF_UID_BOOLEAN_ACE leavig only
OPAL_HALF_UID_AUTHORITY_OBJ_REF. Is that intended and if so why is
OPAL_HALF_UID_BOOLEAN_ACE not needed anymore?