linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
	Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>
Subject: [PATCH blktests v4 01/11] nvme/rc: Auto convert test device size info
Date: Thu, 11 May 2023 16:09:43 +0200	[thread overview]
Message-ID: <20230511140953.17609-2-dwagner@suse.de> (raw)
In-Reply-To: <20230511140953.17609-1-dwagner@suse.de>

Introduce a convert_to_mb() helper which converts the size argument
to MBytes and use in test device require function. This makes it
possible to use user input strings in future.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 common/rc      | 30 +++++++++++++++++++++++++++---
 tests/nvme/035 |  2 +-
 2 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/common/rc b/common/rc
index af4c0b1cab22..f22a7a5eadf8 100644
--- a/common/rc
+++ b/common/rc
@@ -324,9 +324,12 @@ _get_pci_parent_from_blkdev() {
 		tail -2 | head -1
 }
 
-_require_test_dev_size_mb() {
-	local require_sz_mb=$1
-	local test_dev_sz_mb=$(($(blockdev --getsize64 "$TEST_DEV")/1024/1024))
+_require_test_dev_size() {
+	local require_sz_mb
+	local test_dev_sz_mb
+
+	require_sz_mb="$(convert_to_mb "$1")"
+	test_dev_sz_mb="$(($(blockdev --getsize64 "$TEST_DEV")/1024/1024))"
 
 	if (( "$test_dev_sz_mb" < "$require_sz_mb" )); then
 		SKIP_REASONS+=("${TEST_DEV} required at least ${require_sz_mb}m")
@@ -422,3 +425,24 @@ _have_writeable_kmsg() {
 _run_user() {
 	su "$NORMAL_USER" -c "$1"
 }
+
+convert_to_mb()
+{
+	local str=$1
+	local res
+
+	res=$(echo "${str}" | sed -n 's/^\([0-9]\+\)$/\1/p')
+	if [[ -n "${res}" ]]; then
+		echo "$((res / 1024 / 1024))"
+	fi
+
+	res=$(echo "${str}" | sed -n 's/^\([0-9]\+\)[mM]$/\1/p')
+	if [[ -n "${res}" ]]; then
+		echo "$((res))"
+	fi
+
+	res=$(echo "${str}" | sed -n 's/^\([0-9]\+\)[gG]$/\1/p')
+	if [[ -n "${res}" ]]; then
+		echo "$((res * 1024))"
+	fi
+}
diff --git a/tests/nvme/035 b/tests/nvme/035
index d169e351e3d0..eb1024edddbf 100755
--- a/tests/nvme/035
+++ b/tests/nvme/035
@@ -17,7 +17,7 @@ requires() {
 }
 
 device_requires() {
-	_require_test_dev_size_mb 1024
+	_require_test_dev_size 1024m
 }
 
 test_device() {
-- 
2.40.0


  reply	other threads:[~2023-05-11 14:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11 14:09 [PATCH blktests v4 00/11] nvme testsuite runtime optimization Daniel Wagner
2023-05-11 14:09 ` Daniel Wagner [this message]
2023-05-11 14:09 ` [PATCH blktests v4 02/11] nvme{014/015}: Do not hard code device size for dd test Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 03/11] common/xfs: Make size argument optional for _xfs_run_fio_verify_io Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 04/11] common/xfs: Limit fio size job to fit into xfs fs Daniel Wagner
2023-05-17  4:37   ` Chaitanya Kulkarni
2023-05-11 14:09 ` [PATCH blktests v4 05/11] nvme{032,040}: Use runtime fio background jobs Daniel Wagner
2023-05-17  4:40   ` Chaitanya Kulkarni
2023-05-18  7:52     ` Daniel Wagner
2023-05-18  8:38       ` Chaitanya Kulkarni
2023-05-11 14:09 ` [PATCH blktests v4 06/11] Documentation: Add info on nvme_trtype Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 07/11] nvme: Make test image size configurable Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 08/11] nvme: Add minimal test image size requirement Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 09/11] nvme{045,047}: Calculate IO size for random fio jobs Daniel Wagner
2023-05-17  4:44   ` Chaitanya Kulkarni
2023-05-19  1:36     ` Shinichiro Kawasaki
2023-06-01  8:46       ` Daniel Wagner
2023-05-11 14:09 ` [PATCH blktests v4 10/11] nvme{002,030}: Move discovery generation counter code to rc Daniel Wagner
2023-05-13 10:27   ` Chaitanya Kulkarni
2023-05-11 14:09 ` [PATCH blktests v4 11/11] nvme{016,017}: Make the number iterations configurable Daniel Wagner
2023-05-25 23:59 ` [PATCH blktests v4 00/11] nvme testsuite runtime optimization Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230511140953.17609-2-dwagner@suse.de \
    --to=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=shinichiro@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).