From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Jinyoung Choi <j-young.choi@samsung.com>, linux-block@vger.kernel.org
Subject: rationalize the flow in bio_add_page and friends
Date: Fri, 12 May 2023 06:38:53 -0700 [thread overview]
Message-ID: <20230512133901.1053543-1-hch@lst.de> (raw)
Hi Jens,
when reviewing v2 of Jinyoung's "Change the integrity configuration
method in block" series I noticed that someone made a complete mess of
the bio_add_page flow, so this untangles this to make the code better
reusable for adding integrity payloads. (I'll also have a word with
younger me when I get the chance about this..)
Diffstat:
bio.c | 123 ++++++++++++++++++++++++++++--------------------------------------
1 file changed, 53 insertions(+), 70 deletions(-)
next reply other threads:[~2023-05-12 13:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 13:38 Christoph Hellwig [this message]
2023-05-12 13:38 ` [PATCH 1/8] block: tidy up the bio full checks in bio_add_hw_page Christoph Hellwig
2023-05-17 7:18 ` Jinyoung CHOI
2023-05-12 13:38 ` [PATCH 2/8] block: use SECTOR_SHIFT bio_add_hw_page Christoph Hellwig
2023-05-16 12:00 ` Johannes Thumshirn
2023-05-19 6:05 ` Jinyoung CHOI
2023-05-12 13:38 ` [PATCH 3/8] block: move the BIO_CLONED checks out of __bio_try_merge_page Christoph Hellwig
2023-05-16 12:01 ` Johannes Thumshirn
2023-05-19 6:08 ` Jinyoung CHOI
2023-05-12 13:38 ` [PATCH 4/8] block: move the bi_vcnt check " Christoph Hellwig
2023-05-16 12:04 ` Johannes Thumshirn
2023-05-19 6:13 ` Jinyoung CHOI
2023-05-12 13:38 ` [PATCH 5/8] block: move the bi_size overflow check in __bio_try_merge_page Christoph Hellwig
2023-05-16 12:08 ` Johannes Thumshirn
2023-05-19 6:14 ` Jinyoung CHOI
2023-05-12 13:38 ` [PATCH 6/8] block: downgrade a bio_full call in bio_add_page Christoph Hellwig
2023-05-19 6:18 ` Jinyoung CHOI
2023-05-12 13:39 ` [PATCH 7/8] block: move the bi_size update out of __bio_try_merge_page Christoph Hellwig
2023-05-19 6:27 ` Jinyoung CHOI
2023-05-12 13:39 ` [PATCH 8/8] block: don't pass a bio to bio_try_merge_hw_seg Christoph Hellwig
2023-05-19 6:30 ` Jinyoung CHOI
2023-05-19 2:27 ` rationalize the flow in bio_add_page and friends Jens Axboe
2023-05-20 1:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230512133901.1053543-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=j-young.choi@samsung.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).