From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98494C77B7D for ; Sat, 13 May 2023 19:11:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231636AbjEMTLW (ORCPT ); Sat, 13 May 2023 15:11:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229994AbjEMTLV (ORCPT ); Sat, 13 May 2023 15:11:21 -0400 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8831B26BF for ; Sat, 13 May 2023 12:11:20 -0700 (PDT) Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-3f36523e104so60970271cf.2 for ; Sat, 13 May 2023 12:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684005079; x=1686597079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bc2WbLcG4MisgxMfHuVQzIIOIhJWCXgU3kZiHiMOWW4=; b=D6SO0X8GRWtwf0ynq7LE2y9aVEulg4miuzULR4xEFc4KujHO7cKDuJidPi3F99jELX ISZGhz7loktmvxEHKb+92QSKVLIYc7ci1Swp6JRvl+At48WLSf02ulhdtGcwTEuJTlKC diIyVw47kwcT2UgDwdlKiQxdYFDhiwCsD7CYq29mOELiunNhnySAFUSLRRlfcNSm5qFh ie1huEprotIzOST89meE08jDNEZ7nIxd8Vr8VyS57fSIzu1E2BuuInhC5rreeiuiErj/ Nx9OuwzUqYtGhPaAntNUjQ4CdlFGLrtzDKilkx+ZWzjHdb/hgjSAGzVj8yLu3djZMiMV sidA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684005079; x=1686597079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bc2WbLcG4MisgxMfHuVQzIIOIhJWCXgU3kZiHiMOWW4=; b=RfAEvnzRmcVRstZAltswWJKAGWrLJ3VzxDb51C5XCcnLfPnSfdtU1RxRShoQRlewmM tkSQ9DhUZCc/L7NQVXQEy5M5pgk/ywYotrzKa7GyMjgyA2x0x5pfMD0OZgRDb8pP8MYU BYcm87TVezKC1ZUTnkUwiUh3ElfZnIls5yv+a4cbClDN6hkve3WUCbBDpAFopezYwdyR as+pyf6/XMtP0kvnYl0OiVBw6tW5sOFz3UsO49usnQv7KjBPrizPhBL8d83v9E83nOhG OUiYKxhAumWovboEentSUg4TtPGB1IH+t33dI9VK6lVBU2FTLzy74RzoPhh3NBXVGPyR sgeg== X-Gm-Message-State: AC+VfDwHMbqffCkXZJ5EhqF0hVBO6pZnJENO2/q/FVYb01pJVTsOEltZ LSnjqMIeYs0cjInx6xR6Dow= X-Google-Smtp-Source: ACHHUZ7WudFsl2vGq5sl863YxyQc4RJOBzDs06jD/TfKnoM6d2bWarqK6UOQCqwM0oaL+lL7wQw/Fw== X-Received: by 2002:ac8:598a:0:b0:3e6:457f:9ec7 with SMTP id e10-20020ac8598a000000b003e6457f9ec7mr49760258qte.19.1684005079235; Sat, 13 May 2023 12:11:19 -0700 (PDT) Received: from tian-Alienware-15-R4.fios-router.home (pool-173-77-254-84.nycmny.fios.verizon.net. [173.77.254.84]) by smtp.gmail.com with ESMTPSA id f1-20020a05620a12e100b0075939692d18sm282862qkl.83.2023.05.13.12.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 May 2023 12:11:18 -0700 (PDT) From: Tian Lan To: axboe@kernel.dk Cc: lkp@intel.com, linux-block@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, tian.lan@twosigma.com, tilan7663@gmail.com Subject: Re: [PATCH 1/1] blk-mq: fix blk_mq_hw_ctx active request accounting Date: Sat, 13 May 2023 15:11:18 -0400 Message-Id: <20230513191118.331583-1-tilan7663@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <202305140021.WvuGBjaZ-lkp@intel.com> References: <202305140021.WvuGBjaZ-lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Jens, >> The fact that you didn't even compile this not withstanding, why >> not just move the existing check from blk_mq_free_request() to >> __blk_mq_free_request()? Could you please review the change again when you have a chance, I made the change that you suggested earlier. I apologize for the broken patch submitted earlier, we did test the change on our production host and able to confirm the change did address the active request leaking issue. It was totally my fault for not proofreading the change before submitting it to the upstream. Best, Tian