From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH v5 11/11] block: mq-deadline: Fix handling of at-head zoned writes
Date: Tue, 16 May 2023 15:33:20 -0700 [thread overview]
Message-ID: <20230516223323.1383342-12-bvanassche@acm.org> (raw)
In-Reply-To: <20230516223323.1383342-1-bvanassche@acm.org>
Before dispatching a zoned write from the FIFO list, check whether there
are any zoned writes in the RB-tree with a lower LBA for the same zone.
This patch ensures that zoned writes happen in order even if at_head is
set for some writes for a zone and not for others.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/mq-deadline.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/block/mq-deadline.c b/block/mq-deadline.c
index 059727fa4b98..67989f8d29a5 100644
--- a/block/mq-deadline.c
+++ b/block/mq-deadline.c
@@ -346,7 +346,7 @@ static struct request *
deadline_fifo_request(struct deadline_data *dd, struct dd_per_prio *per_prio,
enum dd_data_dir data_dir)
{
- struct request *rq;
+ struct request *rq, *rb_rq, *next;
unsigned long flags;
if (list_empty(&per_prio->fifo_list[data_dir]))
@@ -364,7 +364,12 @@ deadline_fifo_request(struct deadline_data *dd, struct dd_per_prio *per_prio,
* zones and these zones are unlocked.
*/
spin_lock_irqsave(&dd->zone_lock, flags);
- list_for_each_entry(rq, &per_prio->fifo_list[DD_WRITE], queuelist) {
+ list_for_each_entry_safe(rq, next, &per_prio->fifo_list[DD_WRITE],
+ queuelist) {
+ /* Check whether a prior request exists for the same zone. */
+ rb_rq = deadline_from_pos(per_prio, data_dir, blk_rq_pos(rq));
+ if (rb_rq && blk_rq_pos(rb_rq) < blk_rq_pos(rq))
+ rq = rb_rq;
if (blk_req_can_dispatch_to_zone(rq) &&
(blk_queue_nonrot(rq->q) ||
!deadline_is_seq_write(dd, rq)))
next prev parent reply other threads:[~2023-05-16 22:33 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 22:33 [PATCH v5 00/11] mq-deadline: Improve support for zoned block devices Bart Van Assche
2023-05-16 22:33 ` [PATCH v5 01/11] block: Simplify blk_req_needs_zone_write_lock() Bart Van Assche
2023-05-16 23:23 ` Damien Le Moal
2023-05-17 7:36 ` Hannes Reinecke
2023-05-17 10:00 ` Johannes Thumshirn
2023-05-16 22:33 ` [PATCH v5 02/11] block: Fix the type of the second bdev_op_is_zoned_write() argument Bart Van Assche
2023-05-16 23:26 ` Damien Le Moal
2023-05-17 7:37 ` Hannes Reinecke
2023-05-16 22:33 ` [PATCH v5 03/11] block: Introduce op_is_zoned_write() Bart Van Assche
2023-05-16 23:30 ` Damien Le Moal
2023-05-17 0:00 ` Bart Van Assche
2023-05-17 6:45 ` Christoph Hellwig
2023-05-17 6:47 ` Damien Le Moal
2023-05-17 7:37 ` Hannes Reinecke
2023-05-16 22:33 ` [PATCH v5 04/11] block: Introduce blk_rq_is_seq_zoned_write() Bart Van Assche
2023-05-17 0:01 ` Damien Le Moal
2023-05-17 7:38 ` Hannes Reinecke
2023-05-17 10:02 ` Johannes Thumshirn
2023-05-16 22:33 ` [PATCH v5 05/11] block: mq-deadline: Clean up deadline_check_fifo() Bart Van Assche
2023-05-17 1:02 ` Damien Le Moal
2023-05-17 15:01 ` Bart Van Assche
2023-05-17 22:07 ` Damien Le Moal
2023-05-17 7:39 ` Hannes Reinecke
2023-05-16 22:33 ` [PATCH v5 06/11] block: mq-deadline: Simplify deadline_skip_seq_writes() Bart Van Assche
2023-05-17 7:40 ` Hannes Reinecke
2023-05-16 22:33 ` [PATCH v5 07/11] block: mq-deadline: Improve deadline_skip_seq_writes() Bart Van Assche
2023-05-17 1:06 ` Damien Le Moal
2023-05-17 16:30 ` Bart Van Assche
2023-05-17 22:15 ` Damien Le Moal
2023-05-18 18:48 ` Bart Van Assche
2023-05-17 7:41 ` Hannes Reinecke
2023-05-17 7:55 ` Damien Le Moal
2023-05-16 22:33 ` [PATCH v5 08/11] block: mq-deadline: Reduce lock contention Bart Van Assche
2023-05-17 1:07 ` Damien Le Moal
2023-05-17 6:46 ` Christoph Hellwig
2023-05-17 7:42 ` Hannes Reinecke
2023-05-16 22:33 ` [PATCH v5 09/11] block: mq-deadline: Track the dispatch position Bart Van Assche
2023-05-17 1:13 ` Damien Le Moal
2023-05-17 7:45 ` Hannes Reinecke
2023-05-16 22:33 ` [PATCH v5 10/11] block: mq-deadline: Handle requeued requests correctly Bart Van Assche
2023-05-17 1:22 ` Damien Le Moal
2023-05-17 16:28 ` Bart Van Assche
2023-05-17 22:05 ` Damien Le Moal
2023-05-18 12:58 ` Damien Le Moal
2023-05-17 7:46 ` Hannes Reinecke
2023-05-16 22:33 ` Bart Van Assche [this message]
2023-05-17 1:24 ` [PATCH v5 11/11] block: mq-deadline: Fix handling of at-head zoned writes Damien Le Moal
2023-05-17 7:47 ` Hannes Reinecke
2023-05-17 7:53 ` Damien Le Moal
2023-05-17 17:13 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516223323.1383342-12-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).