Linux block layer
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH v6 00/11] mq-deadline: Improve support for zoned block devices
Date: Wed, 17 May 2023 10:42:18 -0700	[thread overview]
Message-ID: <20230517174230.897144-1-bvanassche@acm.org> (raw)

Hi Jens,

This patch series improves support for zoned block devices in the mq-deadline
scheduler by preserving the order of requeued writes (REQ_OP_WRITE and
REQ_OP_WRITE_ZEROES).

Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v5:
- Added a patch with a grammar fix for a source code comment.
- Renamed op_is_zoned_write() into op_needs_zoned_write_locking().
- Dropped patch "block: mq-deadline: Improve deadline_skip_seq_writes()".

Changes compared to v4:
- Changed blk_rq_is_seq_zoned_write() into an inline function.
- Reworked patch "Reduce lock contention" such that all merged requests are
  freed at once.

Changes compared to v3:
- Addressed Christoph's review feedback.
- Dropped patch "block: Micro-optimize blk_req_needs_zone_write_lock()".
- Added three new patches:
  * block: Fix the type of the second bdev_op_is_zoned_write() argument
  * block: Introduce op_is_zoned_write()
  * block: mq-deadline: Reduce lock contention

Changes compared to v2:
- In the patch that micro-optimizes blk_req_needs_zone_write_lock(), inline
  bdev_op_is_zoned_write() instead of modifying it.
- In patch "block: Introduce blk_rq_is_seq_zoned_write()", converted "case
  REQ_OP_ZONE_APPEND" into a source code comment.
- Reworked deadline_skip_seq_writes() as suggested by Christoph.
- Dropped the patch that disabled head insertion for zoned writes.
- Dropped patch "mq-deadline: Fix a race condition related to zoned writes".
- Reworked handling of requeued requests: the 'next_rq' pointer has been
  removed and instead the position of the most recently dispatched request is
  tracked.
- Dropped the patches for tracking zone capacity and for restricting the number
  of active zones.

Changes compared to v1:
- Left out the patches related to request insertion and requeuing since
  Christoph is busy with reworking these patches.
- Added a patch for enforcing the active zone limit.

Bart Van Assche (11):
  block: mq-deadline: Add a word in a source code comment
  block: Simplify blk_req_needs_zone_write_lock()
  block: Fix the type of the second bdev_op_is_zoned_write() argument
  block: Introduce op_needs_zoned_write_locking()
  block: Introduce blk_rq_is_seq_zoned_write()
  block: mq-deadline: Clean up deadline_check_fifo()
  block: mq-deadline: Simplify deadline_skip_seq_writes()
  block: mq-deadline: Reduce lock contention
  block: mq-deadline: Track the dispatch position
  block: mq-deadline: Handle requeued requests correctly
  block: mq-deadline: Fix handling of at-head zoned writes

 block/blk-zoned.c      |   8 +--
 block/mq-deadline.c    | 125 +++++++++++++++++++++++++++--------------
 include/linux/blk-mq.h |  17 ++++++
 include/linux/blkdev.h |  13 +++--
 4 files changed, 110 insertions(+), 53 deletions(-)


             reply	other threads:[~2023-05-17 17:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 17:42 Bart Van Assche [this message]
2023-05-17 17:42 ` [PATCH v6 01/11] block: mq-deadline: Add a word in a source code comment Bart Van Assche
2023-05-18 23:11   ` Damien Le Moal
2023-05-18 23:20     ` Bart Van Assche
2023-05-18 23:39       ` Damien Le Moal
2023-05-17 17:42 ` [PATCH v6 02/11] block: Simplify blk_req_needs_zone_write_lock() Bart Van Assche
2023-05-17 17:42 ` [PATCH v6 03/11] block: Fix the type of the second bdev_op_is_zoned_write() argument Bart Van Assche
2023-05-17 17:42 ` [PATCH v6 04/11] block: Introduce op_needs_zoned_write_locking() Bart Van Assche
2023-05-18 23:12   ` Damien Le Moal
2023-05-17 17:42 ` [PATCH v6 05/11] block: Introduce blk_rq_is_seq_zoned_write() Bart Van Assche
2023-05-18 23:13   ` Damien Le Moal
2023-05-17 17:42 ` [PATCH v6 06/11] block: mq-deadline: Clean up deadline_check_fifo() Bart Van Assche
2023-05-18 23:14   ` Damien Le Moal
2023-05-17 17:42 ` [PATCH v6 07/11] block: mq-deadline: Simplify deadline_skip_seq_writes() Bart Van Assche
2023-05-17 17:42 ` [PATCH v6 08/11] block: mq-deadline: Reduce lock contention Bart Van Assche
2023-05-17 17:42 ` [PATCH v6 09/11] block: mq-deadline: Track the dispatch position Bart Van Assche
2023-05-17 17:42 ` [PATCH v6 10/11] block: mq-deadline: Handle requeued requests correctly Bart Van Assche
2023-05-18 23:15   ` Damien Le Moal
2023-05-17 17:42 ` [PATCH v6 11/11] block: mq-deadline: Fix handling of at-head zoned writes Bart Van Assche
2023-05-19  1:50 ` [PATCH v6 00/11] mq-deadline: Improve support for zoned block devices Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230517174230.897144-1-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox