From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <dlemoal@kernel.org>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 7/7] blk-mq: don't use the requeue list to queue flush commands
Date: Sat, 20 May 2023 06:56:44 +0200 [thread overview]
Message-ID: <20230520045644.GB32182@lst.de> (raw)
In-Reply-To: <36dbbde0-e7f4-c1bd-8015-6265ac812786@acm.org>
On Fri, May 19, 2023 at 12:55:45PM -0700, Bart Van Assche wrote:
>> LIST_HEAD(rq_list);
>> - struct request *rq, *next;
>> + LIST_HEAD(flush_list);
>> + struct request *rq;
>> spin_lock_irq(&q->requeue_lock);
>> list_splice_init(&q->requeue_list, &rq_list);
>> + list_splice_init(&q->flush_list, &flush_list);
>> spin_unlock_irq(&q->requeue_lock);
>
> "rq_list" stands for "request_list". That name is now confusing since this patch
> add a second request list (flush_list).
It is. But I think you were planning on doing a bigger rework in this
area anyway?
next prev parent reply other threads:[~2023-05-20 4:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 4:40 less special casing for flush requests v2 Christoph Hellwig
2023-05-19 4:40 ` [PATCH 1/7] blk-mq: factor out a blk_rq_init_flush helper Christoph Hellwig
2023-05-19 18:54 ` Bart Van Assche
2023-05-19 4:40 ` [PATCH 2/7] blk-mq: reflow blk_insert_flush Christoph Hellwig
2023-05-19 19:38 ` Bart Van Assche
2023-05-19 4:40 ` [PATCH 3/7] blk-mq: defer to the normal submission path for non-flush flush commands Christoph Hellwig
2023-05-19 4:40 ` [PATCH 4/7] blk-mq: use the I/O scheduler for writes from the flush state machine Christoph Hellwig
2023-05-19 19:44 ` Bart Van Assche
2023-05-24 5:53 ` Christoph Hellwig
2023-05-24 18:07 ` Bart Van Assche
2023-05-25 8:14 ` Christoph Hellwig
2023-05-28 20:50 ` Bart Van Assche
2023-05-30 14:55 ` Christoph Hellwig
2023-05-31 13:34 ` Bart Van Assche
2023-05-31 15:00 ` Christoph Hellwig
2023-05-19 4:40 ` [PATCH 5/7] blk-mq: defer to the normal submission path for post-flush requests Christoph Hellwig
2023-05-19 19:42 ` Bart Van Assche
2023-05-19 4:40 ` [PATCH 6/7] blk-mq: do not do head insertions post-pre-flush commands Christoph Hellwig
2023-05-19 4:40 ` [PATCH 7/7] blk-mq: don't use the requeue list to queue flush commands Christoph Hellwig
2023-05-19 19:55 ` Bart Van Assche
2023-05-20 4:56 ` Christoph Hellwig [this message]
2023-05-21 14:06 ` Bart Van Assche
2023-05-20 1:53 ` less special casing for flush requests v2 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2023-04-16 20:09 RFC: less special casing for flush requests Christoph Hellwig
2023-04-16 20:09 ` [PATCH 7/7] blk-mq: don't use the requeue list to queue flush commands Christoph Hellwig
2023-04-16 21:01 ` Bart Van Assche
2023-04-17 4:26 ` Christoph Hellwig
2023-04-17 6:46 ` Damien Le Moal
2023-04-19 12:37 ` kernel test robot
2023-04-19 17:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520045644.GB32182@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).