From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07BE4C83003 for ; Wed, 7 Jun 2023 08:40:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238500AbjFGIkx (ORCPT ); Wed, 7 Jun 2023 04:40:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238524AbjFGIkv (ORCPT ); Wed, 7 Jun 2023 04:40:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B55B1720; Wed, 7 Jun 2023 01:40:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B91C063C4C; Wed, 7 Jun 2023 08:40:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A169C433EF; Wed, 7 Jun 2023 08:40:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686127249; bh=rzaXCmDshhO+LXHkp8rQmS2hilpXNGYeK30nLPS+yX4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fdSp6N+EchetyNQ9ELQAK0k0bpXVcnAL/B1ILfEopTiSUxSrqA68P9/6Fq9lp/rvs 0PdaFTqQtL7hh+98jKmzKvAI22ckdJ6mpUM7tqdfwc59mGXZfc2UZr3+kEZoNF9iCd rNsY4NJ5wPvPPksQ43AYSH5CsJ9ZZPwPKOSRaPn/FQxz7WMErUvxKsWGr8EuIBUbUv GCwjEeBpBb8r5ert952BDHGVamNUJ1fc0KErTkK5SXMdqq0Lpyjam5mGL+HGGvKta5 OZuoqYdC2LP3lItmJ9t7Vn/pgmrJbGFIX1uT/KEmFPNjK+eme8JXQdHwUEcehzKecl PsM6nqwDiF4Hg== Date: Wed, 7 Jun 2023 10:40:40 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 15/31] btrfs: don't pass a holder for non-exclusive blkdev_get_by_path Message-ID: <20230607-dagegen-bandmitglieder-427b6130afcf@brauner> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-16-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230606073950.225178-16-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Jun 06, 2023 at 09:39:34AM +0200, Christoph Hellwig wrote: > Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't > make sense, so pass NULL instead and remove the holder argument from the > call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner