From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-block-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 221B8C7EE29
	for <linux-block@archiver.kernel.org>; Wed,  7 Jun 2023 06:30:32 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235007AbjFGGa2 (ORCPT <rfc822;linux-block@archiver.kernel.org>);
        Wed, 7 Jun 2023 02:30:28 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53334 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S235252AbjFGGaP (ORCPT
        <rfc822;linux-block@vger.kernel.org>); Wed, 7 Jun 2023 02:30:15 -0400
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6664F172B
        for <linux-block@vger.kernel.org>; Tue,  6 Jun 2023 23:30:07 -0700 (PDT)
Received: by verein.lst.de (Postfix, from userid 2407)
        id 6310E68AA6; Wed,  7 Jun 2023 08:30:03 +0200 (CEST)
Date:   Wed, 7 Jun 2023 08:30:02 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Ladislav Michl <oss-lists@triops.cz>
Cc:     linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: ratelimit warning in bio_check_ro
Message-ID: <20230607063002.GA21239@lst.de>
References: <ZIAjht591AEza3c4@lenoch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZIAjht591AEza3c4@lenoch>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-block.vger.kernel.org>
X-Mailing-List: linux-block@vger.kernel.org

On Wed, Jun 07, 2023 at 08:28:22AM +0200, Ladislav Michl wrote:
> From: Ladislav Michl <ladis@linux-mips.org>
> 
> Until 57e95e4670d1 ("block: fix and cleanup bio_check_ro")
> a WARN_ONCE was used to print a warning. Current pr_warn causes
> log flood, so use pr_warn_ratelimited instead.
> Once there adjust message to match the one used in bio_check_eod.

Do you have a case that hits this?  Beause we'd really need to fix it.

Otherwise this looks ok to me.