From: "min.li" <min15.li@samsung.com>
To: axboe@kernel.dk, willy@infradead.org, hch@lst.de,
dlemoal@kernel.org, gregkh@linuxfoundation.org, wsa@kernel.org,
vkoul@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
"min.li" <min15.li@samsung.com>
Subject: [PATCH v3] block: add capacity validation in bdev_add_partition()
Date: Fri, 16 Jun 2023 17:19:13 +0000 [thread overview]
Message-ID: <20230616171913.13045-1-min15.li@samsung.com> (raw)
In-Reply-To: CGME20230616092054epcas5p340e977377808d2df7210dc4a7d6c1d8e@epcas5p3.samsung.com
In the function bdev_add_partition(),there is no check that the start
and end sectors exceed the size of the disk before calling add_partition.
When we call the block's ioctl interface directly to add a partition,
and the capacity of the disk is set to 0 by driver,the command will
continue to execute.
Signed-off-by: min.li <min15.li@samsung.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
Changes from v1:
- Check for overflows of the start + length value.
- Place the capacity check at the beginning of the function.
Changes from v2:
- Place the assignment on the first line and merge the two lines into one.
- Modify the singed name.
---
block/partitions/core.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/block/partitions/core.c b/block/partitions/core.c
index 49e0496ff23c..b511f88bf558 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -436,10 +436,21 @@ static bool partition_overlaps(struct gendisk *disk, sector_t start,
int bdev_add_partition(struct gendisk *disk, int partno, sector_t start,
sector_t length)
{
+ sector_t capacity = get_capacity(disk), end;
struct block_device *part;
int ret;
mutex_lock(&disk->open_mutex);
+ if (check_add_overflow(start, length, &end)) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ if (start >= capacity || end > capacity) {
+ ret = -EINVAL;
+ goto out;
+ }
+
if (!disk_live(disk)) {
ret = -ENXIO;
goto out;
--
2.34.1
next parent reply other threads:[~2023-06-16 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230616092054epcas5p340e977377808d2df7210dc4a7d6c1d8e@epcas5p3.samsung.com>
2023-06-16 17:19 ` min.li [this message]
2023-06-16 11:52 ` [PATCH v3] block: add capacity validation in bdev_add_partition() Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616171913.13045-1-min15.li@samsung.com \
--to=min15.li@samsung.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=willy@infradead.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox