public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "min15.li" <min15.li@samsung.com>
Cc: axboe@kernel.dk, willy@infradead.org, hch@lst.de,
	dlemoal@kernel.org, wsa@kernel.org, vkoul@kernel.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] block: add capacity validation in bdev_add_partition()
Date: Fri, 16 Jun 2023 10:03:28 +0200	[thread overview]
Message-ID: <2023061635-numerous-amplifier-f78b@gregkh> (raw)
In-Reply-To: <20230616110557.12106-1-min15.li@samsung.com>

On Fri, Jun 16, 2023 at 11:05:57AM +0000, min15.li wrote:
> In the function bdev_add_partition(),there is no check that the start
> and end sectors exceed the size of the disk before calling add_partition.
> When we call the block's ioctl interface directly to add a partition,
> and the capacity of the disk is set to 0 by driver,the command will
> continue to execute.
> v1->v2: check for overflows of the start + length value and put
> the capacity check at the beginning of the function.
> 
> Signed-off-by: min15.li <min15.li@samsung.com>

I doubt you sign documents as "min15.li", right? :)

Please fix.

You also forgot a "changes" list below the --- line saying what changed
from the previous submission.

thanks,

greg k-h

      parent reply	other threads:[~2023-06-16  8:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230616030739epcas5p31e705be33bf080f988702d42534ad32f@epcas5p3.samsung.com>
2023-06-16 11:05 ` [PATCH v2] block: add capacity validation in bdev_add_partition() min15.li
2023-06-16  7:17   ` Christoph Hellwig
2023-06-16  8:03   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023061635-numerous-amplifier-f78b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=min15.li@samsung.com \
    --cc=vkoul@kernel.org \
    --cc=willy@infradead.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox