From: Min Li <min15.li@samsung.com>
To: axboe@kernel.dk, willy@infradead.org, hch@lst.de,
dlemoal@kernel.org, gregkh@linuxfoundation.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Min Li <min15.li@samsung.com>
Subject: [PATCH] block: add check that partition length needs to be aligned with block size
Date: Mon, 26 Jun 2023 17:10:21 +0000 [thread overview]
Message-ID: <20230626171021.5895-1-min15.li@samsung.com> (raw)
In-Reply-To: CGME20230626091207epcas5p2a2957dfe97c4d82e39defa557d7ffd0e@epcas5p2.samsung.com
Before calling add partition or resize partition, there is no check
on whether the length is aligned with the logical block size.
If the logical block size of the disk is larger than 512 bytes,
then the partition size maybe not the multiple of the logical block size,
and when the last sector is read, bio_truncate() will adjust the bio size,
resulting in an IO error if the size of the read command is smaller than
the logical block size.If integrity data is supported, this will also
result in a null pointer dereference when calling bio_integrity_free.
Signed-off-by: Min Li <min15.li@samsung.com>
---
block/ioctl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/ioctl.c b/block/ioctl.c
index 9c5f637ff153..aa95b5561169 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -35,6 +35,9 @@ static int blkpg_do_ioctl(struct block_device *bdev,
start = p.start >> SECTOR_SHIFT;
length = p.length >> SECTOR_SHIFT;
+ /*check if length is aligned to blocksize*/
+ if (p.length & (bdev_logical_block_size(bdev) - 1))
+ return -EINVAL;
switch (op) {
case BLKPG_ADD_PARTITION:
--
2.34.1
next parent reply other threads:[~2023-06-26 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230626091207epcas5p2a2957dfe97c4d82e39defa557d7ffd0e@epcas5p2.samsung.com>
2023-06-26 17:10 ` Min Li [this message]
2023-06-26 9:38 ` [PATCH] block: add check that partition length needs to be aligned with block size Damien Le Moal
2023-06-26 14:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626171021.5895-1-min15.li@samsung.com \
--to=min15.li@samsung.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox