From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Ming Lei <ming.lei@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH 3/3] block: Improve performance for BLK_MQ_F_BLOCKING drivers
Date: Tue, 18 Jul 2023 06:54:39 +0200 [thread overview]
Message-ID: <20230718045439.GA8781@lst.de> (raw)
In-Reply-To: <20230717205216.2024545-4-bvanassche@acm.org>
On Mon, Jul 17, 2023 at 01:52:15PM -0700, Bart Van Assche wrote:
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -329,6 +329,9 @@ static void scsi_single_lun_run(struct scsi_device *current_sdev)
> starget->starget_sdev_user = NULL;
> spin_unlock_irqrestore(shost->host_lock, flags);
>
> + /* Combining BLIST_SINGLELUN with BLK_MQ_F_BLOCKING is not supported. */
> + WARN_ON_ONCE(shost->tag_set.flags & BLK_MQ_F_BLOCKING);
.. but it must work. BLIST_SINGLELUN is set for specific targets
based on the identification string while BLK_MQ_F_BLOCKING is set by
the LLDD. Also the blist flags can be set from userspace through
/proc/scsi/device_info.
next prev parent reply other threads:[~2023-07-18 4:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 20:52 [PATCH 0/3] Improve performance for BLK_MQ_F_BLOCKING drivers Bart Van Assche
2023-07-17 20:52 ` [PATCH 1/3] scsi: Inline scsi_kick_queue() Bart Van Assche
2023-07-17 20:52 ` [PATCH 2/3] scsi: Remove a blk_mq_run_hw_queues() call Bart Van Assche
2023-07-17 20:52 ` [PATCH 3/3] block: Improve performance for BLK_MQ_F_BLOCKING drivers Bart Van Assche
2023-07-18 4:54 ` Christoph Hellwig [this message]
2023-07-18 14:25 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718045439.GA8781@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).