From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Damien Le Moal <dlemoal@kernel.org>,
Ming Lei <ming.lei@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH v5 3/7] scsi: core: Retry unaligned zoned writes
Date: Wed, 2 Aug 2023 13:52:09 +0200 [thread overview]
Message-ID: <20230802115209.GA30175@lst.de> (raw)
In-Reply-To: <20230731221458.437440-4-bvanassche@acm.org>
> +/*
> + * Returns a negative value if @_a has a lower LBA than @_b, zero if
> + * both have the same LBA and a positive value otherwise.
> + */
> +static int scsi_cmp_lba(void *priv, const struct list_head *_a,
> + const struct list_head *_b)
> +{
> + struct scsi_cmnd *a = list_entry(_a, typeof(*a), eh_entry);
> + struct scsi_cmnd *b = list_entry(_b, typeof(*b), eh_entry);
> + const sector_t pos_a = blk_rq_pos(scsi_cmd_to_rq(a));
> + const sector_t pos_b = blk_rq_pos(scsi_cmd_to_rq(b));
The SCSI core has no concept of LBAs. Even assuming something like
this is a good idea (and I'm very doubtful) it would have to live
in sd.c.
next prev parent reply other threads:[~2023-08-02 11:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 22:14 [PATCH v5 0/7] Improve the performance for zoned UFS devices Bart Van Assche
2023-07-31 22:14 ` [PATCH v5 1/7] block: Introduce the flag QUEUE_FLAG_NO_ZONE_WRITE_LOCK Bart Van Assche
2023-08-02 9:12 ` Damien Le Moal
2023-07-31 22:14 ` [PATCH v5 2/7] block/mq-deadline: Only use zone locking if necessary Bart Van Assche
2023-08-02 9:12 ` Damien Le Moal
2023-07-31 22:14 ` [PATCH v5 3/7] scsi: core: Retry unaligned zoned writes Bart Van Assche
2023-08-02 9:12 ` Damien Le Moal
2023-08-02 9:16 ` Hannes Reinecke
2023-08-02 9:31 ` Damien Le Moal
2023-08-02 11:52 ` Christoph Hellwig [this message]
2023-08-02 17:20 ` Bart Van Assche
2023-07-31 22:14 ` [PATCH v5 4/7] scsi: scsi_debug: Support disabling zone write locking Bart Van Assche
2023-08-07 18:13 ` Douglas Gilbert
2023-07-31 22:14 ` [PATCH v5 5/7] scsi: scsi_debug: Support injecting unaligned write errors Bart Van Assche
2023-08-07 18:13 ` Douglas Gilbert
2023-07-31 22:14 ` [PATCH v5 6/7] scsi: ufs: Split an if-condition Bart Van Assche
2023-07-31 22:14 ` [PATCH v5 7/7] scsi: ufs: Disable zone write locking Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802115209.GA30175@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).